Android-builders-club/OsmAnd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix testTooManyCapitalLetters wrt unicameral scripts

Browse source 
In v2.6.3, Osmand would keep complaining about too many capital letters
in a name when using any script that doesn't distinguish between upper-
and lowercase such as the CJK family, Arabic, Thai/Lao etc.
This is because the "Character.toUpperCase(c) != c" test could never be
true for those scripts so all characters were classified as uppercase.
The builtin Character.isUpperCase() handles this correctly and is much
clearer, too.
This commit is contained in:
Matthias Bethke 2017-06-26 00:14:02 +10:00
parent ec062fe266
commit 0e7c9b21a2
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
OsmAnd/src/net/osmand/plus/osmedit/EditPoiDialogFragment.java
View file

@ -408,10 +408,10 @@ public class EditPoiDialogFragment extends BaseOsmAndDialogFragment {
for(int i = 0; i < name.length(); i++) {
char c = name.charAt(i);
if(Character.isLetter(c) || Character.getType(c) == Character.LETTER_NUMBER) {
if(Character.toUpperCase(c) != c && Character.toLowerCase(c) == c) {
lower ++;
} else {
if(Character.isUpperCase(c)) {
capital ++;
} else {
lower ++;
}
} else {
nonalpha ++;