Android-builders-club/OsmAnd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Performance: Redundant 'Collection.addAll()' call

Browse source
This commit is contained in:
TacoTheDank 2020-11-19 15:22:11 -05:00
parent 6f60a6298c
commit 0fa24bdc8e
7 changed files with 7 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
OsmAnd-java/src/main/java/com/google/protobuf/FieldSet.java
View file

@ -242,8 +242,7 @@ final class FieldSet<FieldDescriptorType extends
// Wrap the contents in a new list so that the caller cannot change
// the list's contents after setting it.
final List newList = new ArrayList();
newList.addAll((List) value);
final List newList = new ArrayList((List) value);
for (final Object element : newList) {
verifyType(descriptor.getLiteType(), element);
}

3
OsmAnd-java/src/main/java/com/wdtinc/mapbox_vector_tile/adapt/jts/JtsAdapter.java
View file

@ -345,7 +345,6 @@ public final class JtsAdapter {
for(int i = 0; i < geom.getNumGeometries(); ++i) {
final Polygon nextPoly = (Polygon) geom.getGeometryN(i);
final List<Integer> nextPolyGeom = new ArrayList<>();
boolean valid = true;
// Add exterior ring
@ -362,7 +361,7 @@ public final class JtsAdapter {
CoordinateArrays.reverse(exteriorRing.getCoordinates());
}
nextPolyGeom.addAll(linesToGeomCmds(exteriorRing, mvtClosePath, cursor, 2));
final List<Integer> nextPolyGeom = new ArrayList<>(linesToGeomCmds(exteriorRing, mvtClosePath, cursor, 2));
// Add interior rings

3
OsmAnd-java/src/main/java/net/osmand/render/RenderingRulesStorage.java
View file

@ -432,8 +432,7 @@ public class RenderingRulesStorage {
for(RenderingRule ch : caseChildren) {
List<RenderingRule> apply = applyRules;
if(!renderingRule.getIfChildren().isEmpty()) {
apply = new ArrayList<RenderingRule>();
apply.addAll(renderingRule.getIfChildren());
apply = new ArrayList<>(renderingRule.getIfChildren());
if(applyRules != null) {
apply.addAll(applyRules);
}

3
OsmAnd/src/net/osmand/plus/TargetPointsHelper.java
View file

@ -345,8 +345,7 @@ public class TargetPointsHelper {
}
public List<TargetPoint> getIntermediatePointsWithTarget() {
List<TargetPoint> res = new ArrayList<>();
res.addAll(this.intermediatePoints);
List<TargetPoint> res = new ArrayList<>(this.intermediatePoints);
if(pointToNavigate != null) {
res.add(pointToNavigate);
}

3
OsmAnd/src/net/osmand/plus/mapcontextmenu/MenuBuilder.java
View file

@ -367,8 +367,7 @@ public class MenuBuilder {
@Override
public void onFinish(List<ImageCard> cardList) {
if (!isHidden()) {
List<AbstractCard> cards = new ArrayList<>();
cards.addAll(cardList);
List<AbstractCard> cards = new ArrayList<AbstractCard>(cardList);
if (cardList.size() == 0) {
cards.add(new NoImagesCard(mapActivity));
}

3
OsmAnd/src/net/osmand/plus/osmedit/EditPoiDialogFragment.java
View file

@ -427,8 +427,7 @@ public class EditPoiDialogFragment extends BaseOsmAndDialogFragment {
f.setArguments(args);
f.show(getChildFragmentManager(), "exceedDialog");
} else if (TextUtils.isEmpty(poiTypeEditText.getText())) {
HashSet<String> tagsCopy = new HashSet<>();
tagsCopy.addAll(editPoiData.getTagValues().keySet());
new HashSet<>(editPoiData.getTagValues().keySet());
if (Algorithms.isEmpty(editPoiData.getTag(OSMSettings.OSMTagKey.ADDR_HOUSE_NUMBER.getValue()))) {
SaveExtraValidationDialogFragment f = new SaveExtraValidationDialogFragment();
Bundle args = new Bundle();

3
OsmAnd/src/net/osmand/plus/poi/PoiFiltersHelper.java
View file

@ -231,9 +231,8 @@ public class PoiFiltersHelper {
public List<PoiUIFilter> getTopDefinedPoiFilters(boolean includeDeleted) {
List<PoiUIFilter> top = this.cacheTopStandardFilters;
if (top == null) {
top = new ArrayList<>();
// user defined
top.addAll(getUserDefinedPoiFilters(true));
top = new ArrayList<>(getUserDefinedPoiFilters(true));
// default
MapPoiTypes poiTypes = application.getPoiTypes();
for (AbstractPoiType t : poiTypes.getTopVisibleFilters()) {