From c36547a1cbae30fa9893d16512b5e21b506a6ad1 Mon Sep 17 00:00:00 2001 From: Alexey Kulish Date: Sun, 8 Nov 2015 15:21:22 +0300 Subject: [PATCH 01/24] Fix description in context menu --- .../src/net/osmand/plus/AppInitializer.java | 2 +- .../builders/AmenityMenuBuilder.java | 43 +++-- .../controllers/MapDataMenuController.java | 4 +- .../net/osmand/plus/views/POIMapLayer.java | 166 +++++++++++------- 4 files changed, 137 insertions(+), 78 deletions(-) diff --git a/OsmAnd/src/net/osmand/plus/AppInitializer.java b/OsmAnd/src/net/osmand/plus/AppInitializer.java index 42a6b0e626..58d2c97da9 100644 --- a/OsmAnd/src/net/osmand/plus/AppInitializer.java +++ b/OsmAnd/src/net/osmand/plus/AppInitializer.java @@ -281,7 +281,7 @@ public class AppInitializer implements IProgress { @Override public String getTranslation(AbstractPoiType type) { if(type.getBaseLangType() != null) { - return getTranslation(type.getBaseLangType()) + "(" + getLangTranslation(type.getLang()) +")"; + return getTranslation(type.getBaseLangType()) + " (" + getLangTranslation(type.getLang()).toLowerCase() +")"; } try { Field f = R.string.class.getField("poi_" + type.getIconKeyName()); diff --git a/OsmAnd/src/net/osmand/plus/mapcontextmenu/builders/AmenityMenuBuilder.java b/OsmAnd/src/net/osmand/plus/mapcontextmenu/builders/AmenityMenuBuilder.java index 712ca451be..781e597b41 100644 --- a/OsmAnd/src/net/osmand/plus/mapcontextmenu/builders/AmenityMenuBuilder.java +++ b/OsmAnd/src/net/osmand/plus/mapcontextmenu/builders/AmenityMenuBuilder.java @@ -34,11 +34,11 @@ public class AmenityMenuBuilder extends MenuBuilder { this.amenity = amenity; } - private void buildRow(View view, int iconId, String text, int textColor, boolean isWiki, boolean needLinks) { - buildRow(view, getRowIcon(iconId), text, textColor, isWiki, needLinks); + private void buildRow(View view, int iconId, String text, String textPrefix, int textColor, boolean isWiki, boolean isText, boolean needLinks) { + buildRow(view, getRowIcon(iconId), text, textPrefix, textColor, isWiki, isText, needLinks); } - protected void buildRow(final View view, Drawable icon, String text, int textColor, boolean isWiki, boolean needLinks) { + protected void buildRow(final View view, Drawable icon, final String text, final String textPrefix, int textColor, boolean isWiki, boolean isText, boolean needLinks) { boolean light = app.getSettings().isLightContent(); LinearLayout ll = new LinearLayout(view.getContext()); @@ -82,8 +82,15 @@ public class AmenityMenuBuilder extends MenuBuilder { if (isWiki) { textView.setMinLines(1); textView.setMaxLines(15); + } else if (isText) { + textView.setMinLines(1); + textView.setMaxLines(10); + } + if (!Algorithms.isEmpty(textPrefix)) { + textView.setText(textPrefix + ": " + text); + } else { + textView.setText(text); } - textView.setText(text); if (textColor > 0) { textView.setTextColor(view.getResources().getColor(textColor)); } @@ -91,7 +98,14 @@ public class AmenityMenuBuilder extends MenuBuilder { textView.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { - POIMapLayer.showDescriptionDialog(view.getContext(), app, amenity); + POIMapLayer.showWikipediaDialog(view.getContext(), app, amenity); + } + }); + } else if (isText) { + textView.setOnClickListener(new View.OnClickListener() { + @Override + public void onClick(View v) { + POIMapLayer.showDescriptionDialog(view.getContext(), app, text, textPrefix); } }); } @@ -129,7 +143,9 @@ public class AmenityMenuBuilder extends MenuBuilder { String key = e.getKey(); String vl = e.getValue(); + String textPrefix = ""; boolean isWiki = false; + boolean isText = false; boolean needLinks = !"population".equals(key); if (amenity.getType().isWiki()) { @@ -189,21 +205,24 @@ public class AmenityMenuBuilder extends MenuBuilder { if (pType.getParentType() != null && pType.getParentType() instanceof PoiType) { icon = getRowIcon(view.getContext(), ((PoiType) pType.getParentType()).getOsmTag() + "_" + pType.getOsmTag().replace(':', '_') + "_" + pType.getOsmValue()); } - if (pt instanceof PoiType && !((PoiType) pt).isText()) { - vl = pt.getTranslation(); + if (!pType.isText()) { + vl = pType.getTranslation(); } else { - vl = pt.getTranslation() + ": " + amenity.unzipContent(e.getValue()); + isText = true; + iconId = R.drawable.ic_action_note_dark; + textPrefix = pType.getTranslation(); + vl = amenity.unzipContent(e.getValue()); } } else { - vl = Algorithms.capitalizeFirstLetterAndLowercase(e.getKey()) + - ": " + amenity.unzipContent(e.getValue()); + textPrefix = Algorithms.capitalizeFirstLetterAndLowercase(e.getKey()); + vl = amenity.unzipContent(e.getValue()); } } if (icon != null) { - buildRow(view, icon, vl, textColor, isWiki, needLinks); + buildRow(view, icon, vl, textPrefix, textColor, isWiki, isText, needLinks); } else { - buildRow(view, iconId, vl, textColor, isWiki, needLinks); + buildRow(view, iconId, vl, textPrefix, textColor, isWiki, isText, needLinks); } } } diff --git a/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/MapDataMenuController.java b/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/MapDataMenuController.java index e8655f5620..1fc744e354 100644 --- a/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/MapDataMenuController.java +++ b/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/MapDataMenuController.java @@ -153,9 +153,9 @@ public class MapDataMenuController extends MenuController { String[] items = region.getParams().getWikiLink().split(":"); String url; if (items.length > 1) { - url = "https://" + items[0] + ".wikipedia.org/wiki/" + items[1]; + url = "https://" + items[0] + ".wikipedia.org/wiki/" + items[1].replace(' ', '_'); } else { - url = "https://wikipedia.org/wiki/" + items[0]; + url = "https://wikipedia.org/wiki/" + items[0].replace(' ', '_'); } addPlainMenuItem(R.drawable.ic_world_globe_dark, url, true); } diff --git a/OsmAnd/src/net/osmand/plus/views/POIMapLayer.java b/OsmAnd/src/net/osmand/plus/views/POIMapLayer.java index 0e4d34473a..1cea54de45 100644 --- a/OsmAnd/src/net/osmand/plus/views/POIMapLayer.java +++ b/OsmAnd/src/net/osmand/plus/views/POIMapLayer.java @@ -1,10 +1,9 @@ package net.osmand.plus.views; -import android.app.AlertDialog; -import android.app.AlertDialog.Builder; import android.app.Dialog; import android.content.Context; import android.content.Intent; +import android.content.res.Resources; import android.graphics.Bitmap; import android.graphics.BitmapFactory; import android.graphics.Canvas; @@ -18,8 +17,6 @@ import android.net.Uri; import android.support.v4.view.MenuItemCompat; import android.support.v7.widget.PopupMenu; import android.support.v7.widget.Toolbar; -import android.text.SpannableString; -import android.text.method.LinkMovementMethod; import android.text.util.Linkify; import android.util.TypedValue; import android.view.Gravity; @@ -27,6 +24,7 @@ import android.view.MenuItem; import android.view.MenuItem.OnMenuItemClickListener; import android.view.MotionEvent; import android.view.View; +import android.view.ViewGroup; import android.webkit.WebSettings; import android.webkit.WebView; import android.widget.Button; @@ -67,6 +65,8 @@ import java.util.List; import java.util.Set; import java.util.TreeSet; +import static android.util.TypedValue.COMPLEX_UNIT_DIP; + public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.IContextMenuProvider, MapTextProvider, IRouteInformationListener { private static final int startZoom = 9; @@ -86,7 +86,7 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon private RoutingHelper routingHelper; private PoiUIFilter filter; private MapTextLayer mapTextLayer; - + /// cache for displayed POI // Work with cache (for map copied from AmenityIndexRepositoryOdb) private MapLayerData> data; @@ -105,17 +105,17 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon { ZOOM_THRESHOLD = 0; } - + @Override public boolean isInterrupted() { return super.isInterrupted(); } - + @Override public void layerOnPostExecute() { activity.getMapView().refreshMap(); } - + @Override protected List calculateResult(RotatedTileBox tileBox) { QuadRect latLonBounds = tileBox.getLatLonBounds(); @@ -125,18 +125,18 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon int z = (int) Math.floor(tileBox.getZoom() + Math.log(view.getSettings().MAP_DENSITY.get()) / Math.log(2)); List res = filter.searchAmenities(latLonBounds.top, latLonBounds.left, - latLonBounds.bottom, latLonBounds.right, z , new ResultMatcher() { + latLonBounds.bottom, latLonBounds.right, z, new ResultMatcher() { - @Override - public boolean publish(Amenity object) { - return true; - } + @Override + public boolean publish(Amenity object) { + return true; + } - @Override - public boolean isCancelled() { - return isInterrupted(); - } - }); + @Override + public boolean isCancelled() { + return isInterrupted(); + } + }); Collections.sort(res, new Comparator() { @Override @@ -219,9 +219,9 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon @Override public void onPrepareBufferImage(Canvas canvas, RotatedTileBox tileBox, DrawSettings settings) { - if(!Algorithms.objectEquals(this.settings.SELECTED_POI_FILTER_FOR_MAP.get(), + if (!Algorithms.objectEquals(this.settings.SELECTED_POI_FILTER_FOR_MAP.get(), filter == null ? null : filter.getFilterId())) { - if(this.settings.SELECTED_POI_FILTER_FOR_MAP.get() == null) { + if (this.settings.SELECTED_POI_FILTER_FOR_MAP.get() == null) { this.filter = null; } else { PoiFiltersHelper pfh = app.getPoiFilters(); @@ -294,31 +294,21 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon return true; } - public static void showDescriptionDialog(Context ctx, OsmandApplication app, Amenity a) { + public static void showWikipediaDialog(Context ctx, OsmandApplication app, Amenity a) { String lang = app.getSettings().MAP_PREFERRED_LOCALE.get(); if (a.getType().isWiki()) { String preferredLang = lang; - if(Algorithms.isEmpty(preferredLang)) { + if (Algorithms.isEmpty(preferredLang)) { preferredLang = app.getLanguage(); } showWiki(ctx, app, a, preferredLang); - } else { - String d = OsmAndFormatter.getAmenityDescriptionContent(app, a, false); - SpannableString spannable = new SpannableString(d); - Linkify.addLinks(spannable, Linkify.ALL); - - Builder bs = new AlertDialog.Builder(ctx); - bs.setTitle(OsmAndFormatter.getPoiStringWithoutType(a, lang)); - bs.setMessage(spannable); - bs.setPositiveButton(R.string.shared_string_ok, null); - AlertDialog dialog = bs.show(); - // Make links clickable - TextView textView = (TextView) dialog.findViewById(android.R.id.message); - textView.setMovementMethod(LinkMovementMethod.getInstance()); - textView.setLinksClickable(true); } } + public static void showDescriptionDialog(Context ctx, OsmandApplication app, String text, String textPrefix) { + showText(ctx, app, text, textPrefix); + } + static int getResIdFromAttribute(final Context ctx, final int attr) { if (attr == 0) return 0; @@ -326,16 +316,16 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon ctx.getTheme().resolveAttribute(attr, typedvalueattr, true); return typedvalueattr.resourceId; } - - private static void showWiki(final Context ctx,final OsmandApplication app, final Amenity a, final String lang ) { - final Dialog dialog = new Dialog(ctx, + + private static void showWiki(final Context ctx, final OsmandApplication app, final Amenity a, final String lang) { + final Dialog dialog = new Dialog(ctx, app.getSettings().isLightContent() ? - R.style.OsmandLightTheme: - R.style.OsmandDarkTheme); + R.style.OsmandLightTheme : + R.style.OsmandDarkTheme); final String title = a.getName(lang); LinearLayout ll = new LinearLayout(ctx); ll.setOrientation(LinearLayout.VERTICAL); - + final Toolbar topBar = new Toolbar(ctx); topBar.setClickable(true); Drawable back = app.getIconsCache().getIcon(R.drawable.abc_ic_ab_back_mtrl_am_alpha); @@ -345,7 +335,7 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon topBar.setTitleTextColor(ctx.getResources().getColor(getResIdFromAttribute(ctx, R.attr.pstsTextColor))); String lng = a.getContentSelected("content", lang, "en"); - if(Algorithms.isEmpty(lng)) { + if (Algorithms.isEmpty(lng)) { lng = "en"; } @@ -356,13 +346,13 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon bottomBar.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { - String article = "http://"+langSelected.toLowerCase()+".wikipedia.org/wiki/" + title.replace(' ', '_'); + String article = "https://" + langSelected.toLowerCase() + ".wikipedia.org/wiki/" + title.replace(' ', '_'); Intent i = new Intent(Intent.ACTION_VIEW); i.setData(Uri.parse(article)); ctx.startActivity(i); } }); - MenuItem mi = topBar.getMenu().add(langSelected.toUpperCase()).setOnMenuItemClickListener(new OnMenuItemClickListener() { + MenuItem mi = topBar.getMenu().add(langSelected.toUpperCase()).setOnMenuItemClickListener(new OnMenuItemClickListener() { @Override public boolean onMenuItemClick(final MenuItem item) { showPopupLangMenu(ctx, topBar, app, a, dialog); @@ -390,36 +380,79 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon scrollView.addView(wv); dialog.setContentView(ll); wv.setFocusable(true); - wv.setFocusableInTouchMode(true); + wv.setFocusableInTouchMode(true); wv.requestFocus(View.FOCUS_DOWN); wv.setOnTouchListener(new View.OnTouchListener() { @Override public boolean onTouch(View v, MotionEvent event) { switch (event.getAction()) { - case MotionEvent.ACTION_DOWN: - case MotionEvent.ACTION_UP: - if (!v.hasFocus()) { - v.requestFocus(); - } - break; + case MotionEvent.ACTION_DOWN: + case MotionEvent.ACTION_UP: + if (!v.hasFocus()) { + v.requestFocus(); + } + break; } return false; } }); - + dialog.setCancelable(true); - dialog.show(); -// wv.setWebViewClient(); + dialog.show(); } + private static void showText(final Context ctx, final OsmandApplication app, final String text,String textPrefix) { + final Dialog dialog = new Dialog(ctx, + app.getSettings().isLightContent() ? R.style.OsmandLightTheme : R.style.OsmandDarkTheme); - protected static void showPopupLangMenu(final Context ctx, Toolbar tb, - final OsmandApplication app, final Amenity a, final Dialog dialog) { + LinearLayout ll = new LinearLayout(ctx); + ll.setOrientation(LinearLayout.VERTICAL); + + final Toolbar topBar = new Toolbar(ctx); + topBar.setClickable(true); + Drawable back = app.getIconsCache().getIcon(R.drawable.abc_ic_ab_back_mtrl_am_alpha); + topBar.setNavigationIcon(back); + topBar.setTitle(textPrefix); + topBar.setBackgroundColor(ctx.getResources().getColor(getResIdFromAttribute(ctx, R.attr.pstsTabBackground))); + topBar.setTitleTextColor(ctx.getResources().getColor(getResIdFromAttribute(ctx, R.attr.pstsTextColor))); + topBar.setNavigationOnClickListener(new View.OnClickListener() { + @Override + public void onClick(final View v) { + dialog.dismiss(); + } + }); + + final TextView textView = new TextView(ctx); + LinearLayout.LayoutParams llTextParams = new LinearLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT); + int textMargin = dpToPx(app, 10f); + boolean light = app.getSettings().isLightContent(); + textView.setLayoutParams(llTextParams); + textView.setPadding(textMargin, textMargin, textMargin, textMargin); + textView.setTextSize(16); + textView.setTextColor(app.getResources().getColor(light ? R.color.ctx_menu_info_text_light : R.color.ctx_menu_info_text_dark)); + textView.setAutoLinkMask(Linkify.ALL); + textView.setLinksClickable(true); + textView.setText(text); + + ScrollView scrollView = new ScrollView(ctx); + ll.addView(topBar); + LayoutParams lp = new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, 0); + lp.weight = 1; + ll.addView(scrollView, lp); + scrollView.addView(textView); + + dialog.setContentView(ll); + dialog.setCancelable(true); + dialog.show(); + } + + protected static void showPopupLangMenu(final Context ctx, Toolbar tb, + final OsmandApplication app, final Amenity a, final Dialog dialog) { final PopupMenu optionsMenu = new PopupMenu(ctx, tb, Gravity.RIGHT); - Set names = new TreeSet(); + Set names = new TreeSet(); names.addAll(a.getNames("content", "en")); names.addAll(a.getNames("description", "en")); - + for (final String n : names) { String vn = FileNameTranslationHelper.getVoiceName(ctx, n); MenuItem item = optionsMenu.getMenu().add(vn); @@ -433,7 +466,7 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon }); } optionsMenu.show(); - + } @@ -449,7 +482,7 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon public PointDescription getObjectName(Object o) { if (o instanceof Amenity) { return new PointDescription(PointDescription.POINT_TYPE_POI, ((Amenity) o).getName( - view.getSettings().MAP_PREFERRED_LOCALE.get())); + view.getSettings().MAP_PREFERRED_LOCALE.get())); } return null; } @@ -476,7 +509,7 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon } return null; } - + @Override public LatLon getTextLocation(Amenity o) { return o.getLocation(); @@ -500,5 +533,12 @@ public class POIMapLayer extends OsmandMapLayer implements ContextMenuLayer.ICon public void routeWasCancelled() { } - + public static int dpToPx(Context ctx, float dp) { + Resources r = ctx.getResources(); + return (int) TypedValue.applyDimension( + COMPLEX_UNIT_DIP, + dp, + r.getDisplayMetrics() + ); + } } From 789d08f7f027f08345a2cba3827cc29285551ae6 Mon Sep 17 00:00:00 2001 From: Ldm Public Date: Sat, 7 Nov 2015 22:38:54 +0100 Subject: [PATCH 02/24] Translated using Weblate (French) Currently translated at 100.0% (1806 of 1806 strings) --- OsmAnd/res/values-fr/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OsmAnd/res/values-fr/strings.xml b/OsmAnd/res/values-fr/strings.xml index c698f0fbcc..99d19574f1 100644 --- a/OsmAnd/res/values-fr/strings.xml +++ b/OsmAnd/res/values-fr/strings.xml @@ -2061,7 +2061,7 @@ Afghanistan, Albanie, Algérie, Allemagne, Andorre, Angola, Anguilla, Antigua-et Comment télécharger des cartes et définir les paramètres de base Configurer la navigation FAQ - Comment utiliser les greffons + Foire aux questions Affichage de la carte Rechercher de carte Préparer un trajet From 5658292cb5b91e00760180eca7a6fdcec97e6d78 Mon Sep 17 00:00:00 2001 From: Franco Date: Sat, 7 Nov 2015 23:05:28 +0100 Subject: [PATCH 03/24] Translated using Weblate (Argentinean Spanish) Currently translated at 100.0% (1806 of 1806 strings) --- OsmAnd/res/values-es-rAR/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OsmAnd/res/values-es-rAR/strings.xml b/OsmAnd/res/values-es-rAR/strings.xml index 4ef786853f..bbdc7930e5 100644 --- a/OsmAnd/res/values-es-rAR/strings.xml +++ b/OsmAnd/res/values-es-rAR/strings.xml @@ -1928,7 +1928,7 @@ Cómo descargar mapas, configurar ajustes básicos Configuración de navegación Preguntas Frecuentes - Cómo usar los complementos + Preguntas Frecuentes Vista del mapa Busqueda en el mapa Planificación de viaje From 26903788510dd11d856b13f0583b2c19f1d0ef1a Mon Sep 17 00:00:00 2001 From: Franco Date: Sat, 7 Nov 2015 22:56:21 +0100 Subject: [PATCH 04/24] Translated using Weblate (Spanish) Currently translated at 100.0% (1806 of 1806 strings) --- OsmAnd/res/values-es/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OsmAnd/res/values-es/strings.xml b/OsmAnd/res/values-es/strings.xml index e4b6a63511..3bad357842 100644 --- a/OsmAnd/res/values-es/strings.xml +++ b/OsmAnd/res/values-es/strings.xml @@ -1940,7 +1940,7 @@ Cómo descargar mapas, configurar ajustes básicos Configuración de navegación Preguntas Frecuentes - Cómo usar los complementos + Preguntas Frecuentes Vista del mapa Búsqueda en el mapa Planeando un viaje From 1da1b25cbf06ab646f70dd72be73f695c21ee925 Mon Sep 17 00:00:00 2001 From: Alexey Kulish Date: Sun, 8 Nov 2015 19:45:37 +0300 Subject: [PATCH 05/24] Fixes --- .../res/layout/map_context_menu_fragment.xml | 118 ++++++++++++------ .../res/layout/search_history_list_item.xml | 1 + .../plus/mapcontextmenu/MapContextMenu.java | 4 + .../MapContextMenuFragment.java | 69 +++++++++- .../plus/mapcontextmenu/MenuController.java | 6 +- .../mapcontextmenu/MenuTitleController.java | 6 +- .../FavouritePointMenuController.java | 5 + .../controllers/HistoryMenuController.java | 5 + .../ParkingPositionMenuController.java | 5 + .../PointDescriptionMenuController.java | 7 +- .../TargetPointMenuController.java | 5 + .../controllers/WptPtMenuController.java | 5 + 12 files changed, 189 insertions(+), 47 deletions(-) diff --git a/OsmAnd/res/layout/map_context_menu_fragment.xml b/OsmAnd/res/layout/map_context_menu_fragment.xml index 02e743d21d..6ada5a299d 100644 --- a/OsmAnd/res/layout/map_context_menu_fragment.xml +++ b/OsmAnd/res/layout/map_context_menu_fragment.xml @@ -33,13 +33,13 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:baselineAligned="false" + android:layout_marginBottom="16dp" android:orientation="horizontal"> + android:layout_height="match_parent"> - + android:orientation="horizontal"> - + + + + + + + +