Android-builders-club/OsmAnd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Try to fix possible npe

Browse source
This commit is contained in:
Vitaliy 2021-02-11 12:45:14 +02:00
parent 7732c1e7b1
commit 8044f306e2
2 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
OsmAnd/src/net/osmand/plus/mapcontextmenu/MapContextMenu.java
View file

@ -651,7 +651,7 @@ public class MapContextMenu extends MenuTitleController implements StateChangedL
}
private void updateTitle(String address) {
nameStr = address;
setNameStr(address);
getPointDescription().setName(address);
WeakReference<MapContextMenuFragment> fragmentRef = findMenuFragment();
if (fragmentRef != null)

14
OsmAnd/src/net/osmand/plus/mapcontextmenu/MenuTitleController.java
View file

@ -138,6 +138,10 @@ public abstract class MenuTitleController {
}
}
public void setNameStr(@Nullable String nameStr) {
this.nameStr = nameStr != null ? nameStr : "";
}
protected boolean needStreetName() {
MenuController menuController = getMenuController();
boolean res = getObject() != null || Algorithms.isEmpty(getPointDescription().getName());
@ -165,28 +169,28 @@ public abstract class MenuTitleController {
protected void acquireNameAndType() {
String firstNameStr = "";
nameStr = "";
typeStr = "";
commonTypeStr = "";
streetStr = "";
setNameStr("");
MenuController menuController = getMenuController();
if (menuController != null) {
firstNameStr = menuController.getFirstNameStr();
nameStr = menuController.getNameStr();
setNameStr(menuController.getNameStr());
typeStr = menuController.getTypeStr();
commonTypeStr = menuController.getCommonTypeStr();
}
if (Algorithms.isEmpty(nameStr)) {
nameStr = typeStr;
setNameStr(typeStr);
typeStr = commonTypeStr;
} else if (Algorithms.isEmpty(typeStr)) {
typeStr = commonTypeStr;
}
if (!Algorithms.isEmpty(firstNameStr)) {
nameStr = firstNameStr + " (" + nameStr + ")";
setNameStr(firstNameStr + " (" + nameStr + ")");
}
}
@ -204,7 +208,7 @@ public abstract class MenuTitleController {
}
if (displayStreetNameInTitle()) {
nameStr = streetStr;
setNameStr(streetStr);
getPointDescription().setName(nameStr);
}
onSearchAddressDone();