This NPE needs better fix

This commit is contained in:
sonora 2015-01-14 23:03:28 +01:00
parent fef1c68ff1
commit 8e4b3b5693

View file

@ -129,17 +129,15 @@ public class RegionAddressRepositoryBinary implements RegionAddressRepository {
@Override @Override
public synchronized void preloadStreets(City o, ResultMatcher<Street> resultMatcher) { public synchronized void preloadStreets(City o, ResultMatcher<Street> resultMatcher) {
//Looks like o can be null here, question is why //TODO: Check NPE, looks like o can be null here, question is why
if (o!=null) { Collection<Street> streets = o.getStreets();
Collection<Street> streets = o.getStreets(); if(!streets.isEmpty()){
if(!streets.isEmpty()){ return;
return; }
} try {
try { file.preloadStreets(o, BinaryMapIndexReader.buildAddressRequest(resultMatcher));
file.preloadStreets(o, BinaryMapIndexReader.buildAddressRequest(resultMatcher)); } catch (IOException e) {
} catch (IOException e) { log.error("Disk operation failed" , e); //$NON-NLS-1$
log.error("Disk operation failed" , e); //$NON-NLS-1$
}
} }
} }