Android-builders-club/OsmAnd
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Performance: 'List.remove()' called in loop

Browse source
This commit is contained in:
TacoTheDank 2020-11-19 15:20:30 -05:00
parent 6b16170168
commit 901827458f
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
OsmAnd-java/src/main/java/net/osmand/router/TransportStopsRouteReader.java
View file

@ -325,9 +325,7 @@ public class TransportStopsRouteReader {
// merge first part // merge first part
if (commonStopFirst < commonStopSecond if (commonStopFirst < commonStopSecond
|| (commonStopFirst == commonStopSecond && firstSegment.get(0).isMissingStop())) { || (commonStopFirst == commonStopSecond && firstSegment.get(0).isMissingStop())) {
for (int i = 0; i <= commonStopFirst; i++) { firstSegment.subList(0, commonStopFirst + 1).clear();
firstSegment.remove(0);
}
for (int i = commonStopSecond; i >= 0; i--) { for (int i = commonStopSecond; i >= 0; i--) {
firstSegment.add(0, segmentToMerge.get(i)); firstSegment.add(0, segmentToMerge.get(i));
} }