From f675b8d640e96114bc7efdd2de9e05af7c2d7c4a Mon Sep 17 00:00:00 2001 From: Nazar-Kutz Date: Tue, 28 Apr 2020 10:52:14 +0300 Subject: [PATCH 1/7] Fix RTL step 2 --- OsmAnd/res/drawable/bg_right_menu_dark.xml | 12 ++++ OsmAnd/res/drawable/bg_right_menu_light.xml | 12 ++++ OsmAnd/res/layout/note.xml | 5 +- OsmAnd/res/layout/plan_route_info.xml | 4 +- .../res/layout/search_history_list_item.xml | 4 +- OsmAnd/res/values/attrs.xml | 1 + OsmAnd/res/values/styles.xml | 8 ++- OsmAnd/src/net/osmand/AndroidUtils.java | 65 ++++++++++++++++- .../osmand/SecondSplashScreenFragment.java | 2 +- OsmAnd/src/net/osmand/plus/UiUtilities.java | 5 +- .../osmand/plus/activities/MapActivity.java | 8 ++- .../activities/actions/StartGPSStatus.java | 2 +- .../osmand/plus/base/ContextMenuFragment.java | 3 +- .../plus/dashboard/DashSearchFragment.java | 3 +- .../osmand/plus/dashboard/DashboardOnMap.java | 6 +- .../plus/mapcontextmenu/MenuBuilder.java | 2 +- .../other/TrackDetailsMenuFragment.java | 6 +- .../MeasurementToolFragment.java | 6 +- ...veAsNewTrackBottomSheetDialogFragment.java | 18 ++++- .../monitoring/OsmandMonitoringPlugin.java | 10 +-- .../plus/osmedit/AdvancedEditPoiFragment.java | 4 ++ .../plus/osmedit/BasicEditPoiFragment.java | 7 ++ .../plus/osmedit/EditPoiDialogFragment.java | 26 +++++-- .../ChooseRouteFragment.java | 6 +- .../MapRouteInfoMenu.java | 2 +- .../MapRouteInfoMenuFragment.java | 4 +- .../RouteDetailsFragment.java | 72 +++++++++---------- .../WaypointsFragment.java | 2 +- .../cards/PublicTransportCard.java | 7 +- .../osmand/plus/views/OsmandMapTileView.java | 4 +- .../net/osmand/plus/widgets/FlowLayout.java | 13 ++-- 31 files changed, 240 insertions(+), 89 deletions(-) create mode 100644 OsmAnd/res/drawable/bg_right_menu_dark.xml create mode 100644 OsmAnd/res/drawable/bg_right_menu_light.xml diff --git a/OsmAnd/res/drawable/bg_right_menu_dark.xml b/OsmAnd/res/drawable/bg_right_menu_dark.xml new file mode 100644 index 0000000000..8ee6bc688b --- /dev/null +++ b/OsmAnd/res/drawable/bg_right_menu_dark.xml @@ -0,0 +1,12 @@ + + + + + + + + + + + \ No newline at end of file diff --git a/OsmAnd/res/drawable/bg_right_menu_light.xml b/OsmAnd/res/drawable/bg_right_menu_light.xml new file mode 100644 index 0000000000..d277dde63e --- /dev/null +++ b/OsmAnd/res/drawable/bg_right_menu_light.xml @@ -0,0 +1,12 @@ + + + + + + + + + + + \ No newline at end of file diff --git a/OsmAnd/res/layout/note.xml b/OsmAnd/res/layout/note.xml index 0b7dd81ff6..d34b8652ad 100644 --- a/OsmAnd/res/layout/note.xml +++ b/OsmAnd/res/layout/note.xml @@ -20,7 +20,10 @@ android:layout_height="wrap_content" android:minHeight="@dimen/list_item_height" android:paddingLeft="@dimen/list_content_padding" - android:paddingStart="@dimen/list_content_padding"> + android:paddingStart="@dimen/list_content_padding" + android:paddingRight="0dp" + android:paddingEnd="0dp"> + + android:paddingStart="@dimen/list_content_padding" + android:paddingRight="0dp" + android:paddingEnd="0dp"> + diff --git a/OsmAnd/res/values/styles.xml b/OsmAnd/res/values/styles.xml index 8298bc9957..16641055bc 100644 --- a/OsmAnd/res/values/styles.xml +++ b/OsmAnd/res/values/styles.xml @@ -20,17 +20,19 @@ @string/font_roboto_medium ?android:textColorSecondary @dimen/subHeaderMarginLeft + @dimen/subHeaderMarginLeft @@ -430,6 +432,7 @@ @drawable/bg_map_context_menu_dark @drawable/bg_bottom_menu_dark @drawable/bg_left_menu_dark + @drawable/bg_right_menu_dark @drawable/bg_point_editor_view_dark @color/divider_color_dark @color/divider_color_dark @@ -683,7 +686,9 @@ diff --git a/OsmAnd/src/net/osmand/AndroidUtils.java b/OsmAnd/src/net/osmand/AndroidUtils.java index f16cc52e71..be5aa79e6c 100644 --- a/OsmAnd/src/net/osmand/AndroidUtils.java +++ b/OsmAnd/src/net/osmand/AndroidUtils.java @@ -14,6 +14,7 @@ import android.graphics.Matrix; import android.graphics.Paint; import android.graphics.PointF; import android.graphics.Typeface; +import android.graphics.drawable.BitmapDrawable; import android.graphics.drawable.ClipDrawable; import android.graphics.drawable.Drawable; import android.graphics.drawable.LayerDrawable; @@ -662,6 +663,13 @@ public class AndroidUtils { } } + public static Drawable[] getCompoundDrawables(@NonNull TextView tv){ + if (isSupportRTL()) { + return tv.getCompoundDrawablesRelative(); + } + return tv.getCompoundDrawables(); + } + public static void setPadding(View view, int start, int top, int end, int bottom) { if (isSupportRTL()) { view.setPaddingRelative(start, top, end, bottom); @@ -684,14 +692,67 @@ public class AndroidUtils { } public static int getNavigationIconResId(@NonNull Context ctx) { - return getLayoutDirection(ctx) == ViewCompat.LAYOUT_DIRECTION_RTL ? - R.drawable.ic_arrow_forward : R.drawable.ic_arrow_back; + return isLayoutRtl(ctx) ? R.drawable.ic_arrow_forward : R.drawable.ic_arrow_back; + } + + public static Drawable getDrawableForDirection(@NonNull Context ctx, + @NonNull Drawable drawable) { + return isLayoutRtl(ctx) ? getMirroredDrawable(ctx, drawable) : drawable; + } + + public static Drawable getMirroredDrawable(@NonNull Context ctx, + @NonNull Drawable drawable) { + Bitmap bitmap = drawableToBitmap(drawable); + return new BitmapDrawable(ctx.getResources(), flipBitmapHorizontally(bitmap)); + } + + public static Bitmap drawableToBitmap(Drawable drawable) { + if (drawable instanceof BitmapDrawable) { + BitmapDrawable bitmapDrawable = (BitmapDrawable) drawable; + if(bitmapDrawable.getBitmap() != null) { + return bitmapDrawable.getBitmap(); + } + } + + Bitmap bitmap = null; + if(drawable.getIntrinsicWidth() <= 0 || drawable.getIntrinsicHeight() <= 0) { + bitmap = Bitmap.createBitmap(1, 1, Bitmap.Config.ARGB_8888); + } else { + bitmap = Bitmap.createBitmap(drawable.getIntrinsicWidth(), drawable.getIntrinsicHeight(), Bitmap.Config.ARGB_8888); + } + + Canvas canvas = new Canvas(bitmap); + drawable.setBounds(0, 0, canvas.getWidth(), canvas.getHeight()); + drawable.draw(canvas); + return bitmap; + } + + public static Bitmap flipBitmapHorizontally(Bitmap source) { + Matrix matrix = new Matrix(); + matrix.preScale(-1.0f, 1.0f, source.getWidth() / 2f, source.getHeight() / 2f); + return Bitmap.createBitmap(source, 0, 0, source.getWidth(), source.getHeight(), matrix, true); + } + + public static void setTextHorizontalGravity(@NonNull TextView tv, int hGravity) { + if (tv.getContext() != null) { + boolean isLayoutRtl = AndroidUtils.isLayoutRtl(tv.getContext()); + int gravity = Gravity.LEFT; + if (isLayoutRtl && (hGravity == Gravity.START) + || !isLayoutRtl && hGravity == Gravity.END) { + gravity = Gravity.RIGHT; + } + tv.setGravity(gravity); + } } public static boolean isSupportRTL() { return Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1; } + public static boolean isLayoutRtl(Context ctx) { + return isSupportRTL() && getLayoutDirection(ctx) == ViewCompat.LAYOUT_DIRECTION_RTL; + } + public static ArrayList getChildrenViews(ViewGroup vg) { ArrayList result = new ArrayList<>(); for (int i = 0; i < vg.getChildCount(); i++) { diff --git a/OsmAnd/src/net/osmand/SecondSplashScreenFragment.java b/OsmAnd/src/net/osmand/SecondSplashScreenFragment.java index 527c1f6f60..30fa5381c6 100644 --- a/OsmAnd/src/net/osmand/SecondSplashScreenFragment.java +++ b/OsmAnd/src/net/osmand/SecondSplashScreenFragment.java @@ -145,7 +145,7 @@ public class SecondSplashScreenFragment extends BaseOsmAndFragment { } else { elementsPaddingLeft = getNavigationBarWidth(); } - logoLayoutParams.setMargins(0, logoMarginTop, 0, 0); + AndroidUtils.setMargins(logoLayoutParams, 0, logoMarginTop, 0, 0); logo.setPadding(elementsPaddingLeft, 0, elementsPaddingRight, 0); logo.setLayoutParams(logoLayoutParams); view.addView(logo); diff --git a/OsmAnd/src/net/osmand/plus/UiUtilities.java b/OsmAnd/src/net/osmand/plus/UiUtilities.java index e35e246b1f..a1e9f04f6a 100644 --- a/OsmAnd/src/net/osmand/plus/UiUtilities.java +++ b/OsmAnd/src/net/osmand/plus/UiUtilities.java @@ -23,7 +23,6 @@ import android.view.WindowManager; import android.widget.CompoundButton; import android.widget.ImageView; import android.widget.LinearLayout; -import android.widget.SeekBar; import android.widget.TextView; import androidx.annotation.ColorInt; @@ -619,10 +618,10 @@ public class UiUtilities { return new ContextThemeWrapper(context, nightMode ? darkStyle : lightStyle); } - public static void setMargins(View v, int l, int t, int r, int b) { + public static void setMargins(View v, int s, int t, int e, int b) { if (v.getLayoutParams() instanceof ViewGroup.MarginLayoutParams) { ViewGroup.MarginLayoutParams p = (ViewGroup.MarginLayoutParams) v.getLayoutParams(); - p.setMargins(l, t, r, b); + AndroidUtils.setMargins(p, s, t, e, b); v.requestLayout(); } } diff --git a/OsmAnd/src/net/osmand/plus/activities/MapActivity.java b/OsmAnd/src/net/osmand/plus/activities/MapActivity.java index 77a0af2fca..8e343fe5ce 100644 --- a/OsmAnd/src/net/osmand/plus/activities/MapActivity.java +++ b/OsmAnd/src/net/osmand/plus/activities/MapActivity.java @@ -1951,11 +1951,13 @@ public class MapActivity extends OsmandActionBarActivity implements DownloadEven if (settings.DO_NOT_USE_ANIMATIONS.get()) { if (event.getAction() == MotionEvent.ACTION_DOWN) { if (drawerLayout.isDrawerOpen(Gravity.START)) { - int width = AndroidUtils.dpToPx(this, 280); - if (event.getRawX() > width) { + int drawerWidth = AndroidUtils.dpToPx(this, 280); + int screenWidth = AndroidUtils.getScreenWidth(MapActivity.this); + boolean isLayoutRtl = AndroidUtils.isLayoutRtl(app); + if ((!isLayoutRtl && event.getRawX() > drawerWidth) + || (isLayoutRtl && event.getRawX() <= screenWidth - drawerWidth)) { closeDrawer(); } - } } } diff --git a/OsmAnd/src/net/osmand/plus/activities/actions/StartGPSStatus.java b/OsmAnd/src/net/osmand/plus/activities/actions/StartGPSStatus.java index 530c769491..0c64258825 100644 --- a/OsmAnd/src/net/osmand/plus/activities/actions/StartGPSStatus.java +++ b/OsmAnd/src/net/osmand/plus/activities/actions/StartGPSStatus.java @@ -117,7 +117,7 @@ public class StartGPSStatus extends OsmAndAction { final AppCompatCheckBox cb = new AppCompatCheckBox(activity); cb.setText(R.string.shared_string_remember_my_choice); LinearLayout.LayoutParams lp = new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT); - lp.setMargins(dp24, dp8, dp8, dp24); + AndroidUtils.setMargins(lp, dp24, dp8, dp8, dp24); cb.setLayoutParams(lp); cb.setPadding(dp8, 0, 0, 0); int textColorPrimary = ContextCompat.getColor(activity, isNightMode() ? R.color.text_color_primary_dark : R.color.text_color_primary_light); diff --git a/OsmAnd/src/net/osmand/plus/base/ContextMenuFragment.java b/OsmAnd/src/net/osmand/plus/base/ContextMenuFragment.java index 1e0b10ee31..343594a990 100644 --- a/OsmAnd/src/net/osmand/plus/base/ContextMenuFragment.java +++ b/OsmAnd/src/net/osmand/plus/base/ContextMenuFragment.java @@ -287,7 +287,8 @@ public abstract class ContextMenuFragment extends BaseOsmAndFragment { currentMenuState = MenuState.FULL_SCREEN; if (isSingleFragment()) { final TypedValue typedValueAttr = new TypedValue(); - mapActivity.getTheme().resolveAttribute(R.attr.left_menu_view_bg, typedValueAttr, true); + int bgAttrId = AndroidUtils.isLayoutRtl(app) ? R.attr.right_menu_view_bg : R.attr.left_menu_view_bg; + mapActivity.getTheme().resolveAttribute(bgAttrId, typedValueAttr, true); mainView.setBackgroundResource(typedValueAttr.resourceId); mainView.setLayoutParams(new FrameLayout.LayoutParams(getLandscapeWidth(), ViewGroup.LayoutParams.MATCH_PARENT)); } else { diff --git a/OsmAnd/src/net/osmand/plus/dashboard/DashSearchFragment.java b/OsmAnd/src/net/osmand/plus/dashboard/DashSearchFragment.java index 71ae75da3b..322521a880 100644 --- a/OsmAnd/src/net/osmand/plus/dashboard/DashSearchFragment.java +++ b/OsmAnd/src/net/osmand/plus/dashboard/DashSearchFragment.java @@ -29,7 +29,8 @@ public class DashSearchFragment extends DashBaseFragment { View view = getActivity().getLayoutInflater().inflate(R.layout.dash_search_fragment, container, false); TextView searchFor = (TextView) view.findViewById(R.id.search_for); - searchFor.setCompoundDrawablesWithIntrinsicBounds(getMyApplication().getUIUtilities().getThemedIcon(R.drawable.ic_action_search_dark), null, null, null); + AndroidUtils.setCompoundDrawablesWithIntrinsicBounds(searchFor, + getMyApplication().getUIUtilities().getThemedIcon(R.drawable.ic_action_search_dark), null, null, null); searchFor.setCompoundDrawablePadding(AndroidUtils.dpToPx(getActivity(), 16f)); view.findViewById(R.id.search_card).setOnClickListener(new View.OnClickListener() { diff --git a/OsmAnd/src/net/osmand/plus/dashboard/DashboardOnMap.java b/OsmAnd/src/net/osmand/plus/dashboard/DashboardOnMap.java index 243750ecd8..fca947ca37 100644 --- a/OsmAnd/src/net/osmand/plus/dashboard/DashboardOnMap.java +++ b/OsmAnd/src/net/osmand/plus/dashboard/DashboardOnMap.java @@ -395,9 +395,9 @@ public class DashboardOnMap implements ObservableScrollViewCallbacks, IRouteInfo private FrameLayout.LayoutParams getActionButtonLayoutParams(int btnSizePx) { int topPadPx = mapActivity.getResources().getDimensionPixelSize(R.dimen.dashboard_map_top_padding); FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(btnSizePx, btnSizePx); - int marginRight = btnSizePx / 4; - params.setMargins(0, landscape ? 0 : topPadPx - 2 * btnSizePx, marginRight, landscape ? marginRight : 0); - params.gravity = landscape ? Gravity.BOTTOM | Gravity.RIGHT : Gravity.TOP | Gravity.RIGHT; + int marginEnd = btnSizePx / 4; + AndroidUtils.setMargins(params, 0, landscape ? 0 : topPadPx - 2 * btnSizePx, marginEnd, landscape ? marginEnd : 0); + params.gravity = landscape ? Gravity.BOTTOM | Gravity.END : Gravity.TOP | Gravity.END; return params; } diff --git a/OsmAnd/src/net/osmand/plus/mapcontextmenu/MenuBuilder.java b/OsmAnd/src/net/osmand/plus/mapcontextmenu/MenuBuilder.java index 12ed950536..aa2d5de59b 100644 --- a/OsmAnd/src/net/osmand/plus/mapcontextmenu/MenuBuilder.java +++ b/OsmAnd/src/net/osmand/plus/mapcontextmenu/MenuBuilder.java @@ -1112,7 +1112,7 @@ public class MenuBuilder { } else { button.setTextColor(ContextCompat.getColor(context, light ? R.color.text_color_primary_light : R.color.text_color_primary_dark)); } - button.setGravity(Gravity.LEFT | Gravity.CENTER_VERTICAL); + button.setGravity(Gravity.START | Gravity.CENTER_VERTICAL); button.setSingleLine(singleLine); button.setEllipsize(TextUtils.TruncateAt.END); diff --git a/OsmAnd/src/net/osmand/plus/mapcontextmenu/other/TrackDetailsMenuFragment.java b/OsmAnd/src/net/osmand/plus/mapcontextmenu/other/TrackDetailsMenuFragment.java index 1ee6d9ee03..fad7483291 100644 --- a/OsmAnd/src/net/osmand/plus/mapcontextmenu/other/TrackDetailsMenuFragment.java +++ b/OsmAnd/src/net/osmand/plus/mapcontextmenu/other/TrackDetailsMenuFragment.java @@ -3,6 +3,7 @@ package net.osmand.plus.mapcontextmenu.other; import android.graphics.drawable.Drawable; import android.os.Build; import android.os.Bundle; +import android.util.TypedValue; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; @@ -195,7 +196,10 @@ public class TrackDetailsMenuFragment extends BaseOsmAndFragment { if (!landscapeLayout) { AndroidUtils.setBackground(ctx, mainView, nightMode, R.drawable.bg_bottom_menu_light, R.drawable.bg_bottom_menu_dark); } else { - AndroidUtils.setBackground(ctx, mainView, nightMode, R.drawable.bg_left_menu_light, R.drawable.bg_left_menu_dark); + final TypedValue typedValueAttr = new TypedValue(); + int bgAttrId = AndroidUtils.isLayoutRtl(ctx) ? R.attr.right_menu_view_bg : R.attr.left_menu_view_bg; + ctx.getTheme().resolveAttribute(bgAttrId, typedValueAttr, true); + mainView.setBackgroundResource(typedValueAttr.resourceId); } AndroidUtils.setTextPrimaryColor(ctx, (TextView) mainView.findViewById(R.id.y_axis_title), nightMode); diff --git a/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java b/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java index c084448d7d..a929b7cc35 100644 --- a/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java +++ b/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java @@ -296,7 +296,8 @@ public class MeasurementToolFragment extends BaseOsmAndFragment { undoBtn = ((ImageButton) mainView.findViewById(R.id.undo_point_button)); redoBtn = ((ImageButton) mainView.findViewById(R.id.redo_point_button)); - undoBtn.setImageDrawable(getContentIcon(R.drawable.ic_action_undo_dark)); + Drawable undoDrawable = getContentIcon(R.drawable.ic_action_undo_dark); + undoBtn.setImageDrawable(AndroidUtils.getDrawableForDirection(mapActivity, undoDrawable)); undoBtn.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View view) { @@ -316,7 +317,8 @@ public class MeasurementToolFragment extends BaseOsmAndFragment { } }); - redoBtn.setImageDrawable(getContentIcon(R.drawable.ic_action_redo_dark)); + Drawable redoDrawable = getContentIcon(R.drawable.ic_action_redo_dark); + redoBtn.setImageDrawable(AndroidUtils.getDrawableForDirection(mapActivity, redoDrawable)); redoBtn.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View view) { diff --git a/OsmAnd/src/net/osmand/plus/measurementtool/SaveAsNewTrackBottomSheetDialogFragment.java b/OsmAnd/src/net/osmand/plus/measurementtool/SaveAsNewTrackBottomSheetDialogFragment.java index b2498bda2f..06fd73b966 100644 --- a/OsmAnd/src/net/osmand/plus/measurementtool/SaveAsNewTrackBottomSheetDialogFragment.java +++ b/OsmAnd/src/net/osmand/plus/measurementtool/SaveAsNewTrackBottomSheetDialogFragment.java @@ -1,5 +1,6 @@ package net.osmand.plus.measurementtool; +import android.graphics.drawable.Drawable; import android.os.Build; import android.os.Bundle; import android.view.ContextThemeWrapper; @@ -7,6 +8,10 @@ import android.view.MotionEvent; import android.view.View; import android.widget.ImageView; +import androidx.core.content.ContextCompat; + +import net.osmand.AndroidUtils; +import net.osmand.plus.OsmandApplication; import net.osmand.plus.R; import net.osmand.plus.base.MenuBottomSheetDialogFragment; import net.osmand.plus.base.bottomsheetmenu.BaseBottomSheetItem; @@ -26,6 +31,11 @@ public class SaveAsNewTrackBottomSheetDialogFragment extends MenuBottomSheetDial @Override public void createMenuItems(Bundle savedInstanceState) { + OsmandApplication app = getMyApplication(); + if (app == null) { + return; + } + items.add(new TitleItem(getString(R.string.shared_string_save_as_gpx))); items.add(new ShortDescriptionItem(getString(R.string.measurement_tool_save_as_new_track_descr))); @@ -37,12 +47,16 @@ public class SaveAsNewTrackBottomSheetDialogFragment extends MenuBottomSheetDial final ImageView routePointImage = (ImageView) imagesRow.findViewById(R.id.route_point_image); final ImageView lineImage = (ImageView) imagesRow.findViewById(R.id.line_image); - routePointImage.setImageResource(nightMode + Drawable routePointDrawable = ContextCompat.getDrawable(app, nightMode ? R.drawable.img_help_trip_route_points_night : R.drawable.img_help_trip_route_points_day); - lineImage.setImageResource(nightMode + Drawable lineDrawable = ContextCompat.getDrawable(app, nightMode ? R.drawable.img_help_trip_track_night : R.drawable.img_help_trip_track_day); + if (routePointDrawable != null && lineDrawable != null) { + routePointImage.setImageDrawable(AndroidUtils.getDrawableForDirection(app, routePointDrawable)); + lineImage.setImageDrawable(AndroidUtils.getDrawableForDirection(app, lineDrawable)); + } routePointImage.setOnClickListener(saveAsRoutePointOnClickListener); lineImage.setOnClickListener(saveAsLineOnClickListener); diff --git a/OsmAnd/src/net/osmand/plus/monitoring/OsmandMonitoringPlugin.java b/OsmAnd/src/net/osmand/plus/monitoring/OsmandMonitoringPlugin.java index cd92b36ab9..8dbd3d3d0f 100644 --- a/OsmAnd/src/net/osmand/plus/monitoring/OsmandMonitoringPlugin.java +++ b/OsmAnd/src/net/osmand/plus/monitoring/OsmandMonitoringPlugin.java @@ -573,9 +573,9 @@ public class OsmandMonitoringPlugin extends OsmandPlugin { cb.setTextColor(textColorPrimary); LinearLayout.LayoutParams lp = new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT); - lp.setMargins(dp24, dp8, dp24, 0); + AndroidUtils.setMargins(lp, dp24, dp8, dp24, 0); cb.setLayoutParams(lp); - cb.setPadding(dp8, 0, 0, 0); + AndroidUtils.setPadding(cb, dp8, 0, 0, 0); cb.setChecked(!choice.value); cb.setOnCheckedChangeListener(new OnCheckedChangeListener() { @Override @@ -590,7 +590,7 @@ public class OsmandMonitoringPlugin extends OsmandPlugin { if (showTrackSelection) { View divider = new View(uiCtx); LinearLayout.LayoutParams lp = new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, AndroidUtils.dpToPx(uiCtx, 1f)); - lp.setMargins(0, dp8 * 2, 0, 0); + AndroidUtils.setMargins(lp, 0, dp8 * 2, 0, 0); divider.setLayoutParams(lp); divider.setBackgroundColor(uiCtx.getResources().getColor(nightMode ? R.color.divider_color_dark : R.color.divider_color_light)); ll.addView(divider); @@ -600,9 +600,9 @@ public class OsmandMonitoringPlugin extends OsmandPlugin { cb.setTextColor(textColorPrimary); lp = new LinearLayout.LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.WRAP_CONTENT); - lp.setMargins(dp24, dp8 * 2, dp24, 0); + AndroidUtils.setMargins(lp, dp24, dp8 * 2, dp24, 0); cb.setLayoutParams(lp); - cb.setPadding(dp8, 0, 0, 0); + AndroidUtils.setPadding(cb, dp8, 0, 0, 0); cb.setChecked(app.getSelectedGpxHelper().getSelectedCurrentRecordingTrack() != null); cb.setOnCheckedChangeListener(new OnCheckedChangeListener() { diff --git a/OsmAnd/src/net/osmand/plus/osmedit/AdvancedEditPoiFragment.java b/OsmAnd/src/net/osmand/plus/osmedit/AdvancedEditPoiFragment.java index e640f9da50..541df2c7f6 100644 --- a/OsmAnd/src/net/osmand/plus/osmedit/AdvancedEditPoiFragment.java +++ b/OsmAnd/src/net/osmand/plus/osmedit/AdvancedEditPoiFragment.java @@ -7,6 +7,7 @@ import android.text.Editable; import android.text.InputFilter; import android.text.TextWatcher; import android.view.ContextThemeWrapper; +import android.view.Gravity; import android.view.LayoutInflater; import android.view.View; import android.view.View.OnFocusChangeListener; @@ -21,6 +22,7 @@ import android.widget.TextView; import androidx.annotation.NonNull; import androidx.annotation.Nullable; +import net.osmand.AndroidUtils; import net.osmand.PlatformUtil; import net.osmand.osm.AbstractPoiType; import net.osmand.osm.MapPoiTypes; @@ -202,6 +204,7 @@ public class AdvancedEditPoiFragment extends BaseOsmAndFragment .inflate(R.layout.poi_tag_list_item, null, false); final AutoCompleteTextView tagEditText = (AutoCompleteTextView) convertView.findViewById(R.id.tagEditText); + AndroidUtils.setTextHorizontalGravity(tagEditText, Gravity.START); ImageButton deleteItemImageButton = (ImageButton) convertView.findViewById(R.id.deleteItemImageButton); deleteItemImageButton.setImageDrawable(deleteDrawable); @@ -215,6 +218,7 @@ public class AdvancedEditPoiFragment extends BaseOsmAndFragment }); final AutoCompleteTextView valueEditText = (AutoCompleteTextView) convertView.findViewById(R.id.valueEditText); + AndroidUtils.setTextHorizontalGravity(valueEditText, Gravity.START); valueEditText.setFilters(new InputFilter[] { new InputFilter.LengthFilter(AMENITY_TEXT_LENGTH) }); diff --git a/OsmAnd/src/net/osmand/plus/osmedit/BasicEditPoiFragment.java b/OsmAnd/src/net/osmand/plus/osmedit/BasicEditPoiFragment.java index c9455a9c15..dcf4846f7f 100644 --- a/OsmAnd/src/net/osmand/plus/osmedit/BasicEditPoiFragment.java +++ b/OsmAnd/src/net/osmand/plus/osmedit/BasicEditPoiFragment.java @@ -10,6 +10,7 @@ import android.text.TextUtils; import android.text.TextWatcher; import android.util.TypedValue; import android.view.ContextThemeWrapper; +import android.view.Gravity; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; @@ -24,6 +25,7 @@ import androidx.annotation.NonNull; import androidx.annotation.Nullable; import androidx.fragment.app.Fragment; +import net.osmand.AndroidUtils; import net.osmand.PlatformUtil; import net.osmand.osm.edit.OSMSettings; import net.osmand.plus.R; @@ -104,6 +106,11 @@ public class BasicEditPoiFragment extends BaseOsmAndFragment phoneEditText.setFilters(lengthLimit); webSiteEditText.setFilters(lengthLimit); descriptionEditText.setFilters(lengthLimit); + AndroidUtils.setTextHorizontalGravity(streetEditText, Gravity.START); + AndroidUtils.setTextHorizontalGravity(houseNumberEditText, Gravity.START); + AndroidUtils.setTextHorizontalGravity(phoneEditText, Gravity.START); + AndroidUtils.setTextHorizontalGravity(webSiteEditText, Gravity.START); + AndroidUtils.setTextHorizontalGravity(descriptionEditText, Gravity.START); Button addOpeningHoursButton = (Button) view.findViewById(R.id.addOpeningHoursButton); addOpeningHoursButton.setOnClickListener(new View.OnClickListener() { @Override diff --git a/OsmAnd/src/net/osmand/plus/osmedit/EditPoiDialogFragment.java b/OsmAnd/src/net/osmand/plus/osmedit/EditPoiDialogFragment.java index b4c376f0cd..ce527c5ca0 100644 --- a/OsmAnd/src/net/osmand/plus/osmedit/EditPoiDialogFragment.java +++ b/OsmAnd/src/net/osmand/plus/osmedit/EditPoiDialogFragment.java @@ -16,6 +16,7 @@ import android.text.Editable; import android.text.TextUtils; import android.text.TextWatcher; import android.util.TypedValue; +import android.view.Gravity; import android.view.KeyEvent; import android.view.LayoutInflater; import android.view.MotionEvent; @@ -247,6 +248,7 @@ public class EditPoiDialogFragment extends BaseOsmAndDialogFragment { }); EditText poiNameEditText = (EditText) view.findViewById(R.id.poiNameEditText); + AndroidUtils.setTextHorizontalGravity(poiNameEditText, Gravity.START); poiNameEditText.addTextChangedListener(new TextWatcher() { @Override public void beforeTextChanged(CharSequence s, int start, int count, int after) { @@ -273,6 +275,7 @@ public class EditPoiDialogFragment extends BaseOsmAndDialogFragment { AndroidUtils.showSoftKeyboard(poiNameEditText); poiTypeTextInputLayout = (TextInputLayout) view.findViewById(R.id.poiTypeTextInputLayout); poiTypeEditText = (AutoCompleteTextView) view.findViewById(R.id.poiTypeEditText); + AndroidUtils.setTextHorizontalGravity(poiTypeEditText, Gravity.START); poiTypeEditText.setText(editPoiData.getPoiTypeString()); poiTypeEditText.addTextChangedListener(new TextWatcher() { @Override @@ -301,12 +304,26 @@ public class EditPoiDialogFragment extends BaseOsmAndDialogFragment { poiTypeEditText.setOnTouchListener(new View.OnTouchListener() { @Override public boolean onTouch(final View v, MotionEvent event) { + Context ctx = getContext(); + if (ctx == null) { + return false; + } + boolean isLayoutRtl = AndroidUtils.isLayoutRtl(getContext()); final EditText editText = (EditText) v; - final int DRAWABLE_RIGHT = 2; if (event.getAction() == MotionEvent.ACTION_UP) { - if (event.getX() >= (editText.getRight() - - editText.getCompoundDrawables()[DRAWABLE_RIGHT].getBounds().width() - - editText.getPaddingRight())) { + final int DRAWABLE_END = 2; + int expandBtnWidth = AndroidUtils.getCompoundDrawables(editText)[DRAWABLE_END].getBounds().width(); + + boolean expandButtonPressed = false; + if (isLayoutRtl) { + expandButtonPressed = event.getX() <= (editText.getLeft() + expandBtnWidth + + editText.getPaddingLeft()); + } else { + expandButtonPressed = event.getX() >= (editText.getRight() - expandBtnWidth + - editText.getPaddingRight()); + } + + if (expandButtonPressed) { PoiCategory category = editPoiData.getPoiCategory(); if (category != null) { PoiSubTypeDialogFragment dialogFragment = @@ -319,7 +336,6 @@ public class EditPoiDialogFragment extends BaseOsmAndDialogFragment { }); dialogFragment.show(getChildFragmentManager(), "PoiSubTypeDialogFragment"); } - return true; } } diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java index 77f4a1d442..af0a286930 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java @@ -327,11 +327,11 @@ public class ChooseRouteFragment extends BaseOsmAndFragment implements ContextMe active ? R.drawable.pages_active_light : R.drawable.pages_inactive_light, active ? R.drawable.pages_active_dark : R.drawable.pages_inactive_dark); if (i == 0) { - layoutParams.setMargins(itemMargin, 0, itemPadding, 0); + AndroidUtils.setMargins(layoutParams, itemMargin, 0, itemPadding, 0); } else if (i == routesCount - 1) { - layoutParams.setMargins(0, 0, itemMargin, 0); + AndroidUtils.setMargins(layoutParams, 0, 0, itemMargin, 0); } else { - layoutParams.setMargins(0, 0, itemPadding, 0); + AndroidUtils.setMargins(layoutParams, 0, 0, itemPadding, 0); } itemView.setLayoutParams(layoutParams); pagesView.addView(itemView); diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenu.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenu.java index e16c872c91..1358390802 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenu.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenu.java @@ -1004,7 +1004,7 @@ public class MapRouteInfoMenu implements IRouteInformationListener, CardListener optionsTitle.setVisibility(View.VISIBLE); endPadding += AndroidUtils.getTextWidth(app.getResources().getDimensionPixelSize(R.dimen.text_button_text_size), app.getString(R.string.shared_string_options)); } - if (AndroidUtils.getLayoutDirection(app) == View.LAYOUT_DIRECTION_RTL) { + if (AndroidUtils.isLayoutRtl(app)) { optionsContainer.setPadding(endPadding, optionsContainer.getPaddingTop(), optionsContainer.getPaddingRight(), optionsContainer.getPaddingBottom()); } else { // LTR optionsContainer.setPadding(optionsContainer.getPaddingLeft(), optionsContainer.getPaddingTop(), endPadding, optionsContainer.getPaddingBottom()); diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenuFragment.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenuFragment.java index b5e610c60b..fb59e8e148 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenuFragment.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/MapRouteInfoMenuFragment.java @@ -128,10 +128,10 @@ public class MapRouteInfoMenuFragment extends ContextMenuFragment { int widthNoShadow = getLandscapeNoShadowWidth(); modesLayoutToolbar.setLayoutParams(new FrameLayout.LayoutParams(widthNoShadow, ViewGroup.LayoutParams.WRAP_CONTENT)); FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(widthNoShadow, ViewGroup.LayoutParams.WRAP_CONTENT); - params.gravity = Gravity.BOTTOM; + params.gravity = Gravity.BOTTOM|Gravity.START; view.findViewById(R.id.control_buttons).setLayoutParams(params); View appModesView = view.findViewById(R.id.app_modes); - appModesView.setPadding(0, 0, appModesView.getPaddingRight(), 0); + AndroidUtils.setPadding(appModesView, 0, 0, appModesView.getPaddingRight(), 0); } } return view; diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/RouteDetailsFragment.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/RouteDetailsFragment.java index a645fa64a5..f0a0550400 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/RouteDetailsFragment.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/RouteDetailsFragment.java @@ -186,7 +186,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT view.findViewById(getBottomScrollViewId()).setBackgroundDrawable(null); LinearLayout cardsContainer = getCardsContainer(); FrameLayout.LayoutParams layoutParams = (FrameLayout.LayoutParams) cardsContainer.getLayoutParams(); - layoutParams.setMargins(pageMarginPx, 0, pageMarginPx, 0); + AndroidUtils.setMargins(layoutParams, pageMarginPx, 0, pageMarginPx, 0); cardsContainer.setLayoutParams(layoutParams); updateCardsLayout(); } @@ -459,7 +459,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT ImageView routeLine = new ImageView(view.getContext()); FrameLayout.LayoutParams routeLineParams = new FrameLayout.LayoutParams(dpToPx(8f), ViewGroup.LayoutParams.MATCH_PARENT); routeLineParams.gravity = Gravity.START; - routeLineParams.setMargins(dpToPx(24), dpToPx(14), dpToPx(22), dpToPx(36)); + AndroidUtils.setMargins(routeLineParams, dpToPx(24), dpToPx(14), dpToPx(22), dpToPx(36)); routeLine.setLayoutParams(routeLineParams); int bgColor = transportStopRoute.getColor(app, isNightMode()); routeLine.setBackgroundColor(bgColor); @@ -595,7 +595,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT private View createImagesContainer(@NonNull Context context) { LinearLayout imagesContainer = new LinearLayout(context); FrameLayout.LayoutParams imagesContainerParams = new FrameLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.MATCH_PARENT); - imagesContainer.setPadding(dpToPx(16), dpToPx(12), dpToPx(24), 0); + AndroidUtils.setPadding(imagesContainer, dpToPx(16), dpToPx(12), dpToPx(24), 0); imagesContainer.setOrientation(LinearLayout.VERTICAL); imagesContainer.setLayoutParams(imagesContainerParams); return imagesContainer; @@ -745,7 +745,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT ImageView walkLineImage = new ImageView(container.getContext()); walkLineImage.setImageDrawable(app.getUIUtilities().getIcon(R.drawable.walk_route_item_light)); LinearLayout.LayoutParams walkImageLayoutParams = new LinearLayout.LayoutParams(dpToPx(10), dpToPx(14)); - walkImageLayoutParams.setMargins(dpToPx(7), dpToPx(6), 0, dpToPx(6)); + AndroidUtils.setMargins(walkImageLayoutParams, dpToPx(7), dpToPx(6), 0, dpToPx(6)); walkLineImage.setLayoutParams(walkImageLayoutParams); container.addView(walkLineImage); } @@ -862,12 +862,12 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT LinearLayout llIconCollapse = new LinearLayout(view.getContext()); llIconCollapse.setLayoutParams(new LinearLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, dpToPx(48f))); llIconCollapse.setOrientation(LinearLayout.HORIZONTAL); - llIconCollapse.setGravity(Gravity.CENTER_VERTICAL); + llIconCollapse.setGravity(Gravity.CENTER_VERTICAL|Gravity.START); ll.addView(llIconCollapse); LinearLayout.LayoutParams llIconCollapseParams = new LinearLayout.LayoutParams(dpToPx(24f), dpToPx(24f)); - llIconCollapseParams.setMargins(0, dpToPx(12f), 0, dpToPx(12f)); - llIconCollapseParams.gravity = Gravity.CENTER_VERTICAL; + AndroidUtils.setMargins(llIconCollapseParams,0, dpToPx(12f), 0, dpToPx(12f)); + llIconCollapseParams.gravity = Gravity.CENTER_VERTICAL|Gravity.START; iconViewCollapse.setLayoutParams(llIconCollapseParams); iconViewCollapse.setScaleType(ImageView.ScaleType.CENTER_INSIDE); iconViewCollapse.setImageDrawable(getCollapseIcon(collapsableView.getContenView().getVisibility() == View.GONE)); @@ -934,13 +934,13 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT ImageView iconView = new ImageView(view.getContext()); iconView.setImageDrawable(icon); FrameLayout.LayoutParams imageViewLayoutParams = new FrameLayout.LayoutParams(dpToPx(28), dpToPx(28)); - imageViewLayoutParams.gravity = Gravity.TOP; + imageViewLayoutParams.gravity = Gravity.TOP|Gravity.START; iconView.setLayoutParams(imageViewLayoutParams); iconView.setScaleType(ImageView.ScaleType.CENTER_INSIDE); - imageViewLayoutParams.setMargins(dpToPx(14), dpToPx(8), dpToPx(22), 0); + AndroidUtils.setMargins(imageViewLayoutParams, dpToPx(14), dpToPx(8), dpToPx(22), 0); iconView.setBackgroundResource(R.drawable.border_round_solid_light); - iconView.setPadding(dpToPx(2), dpToPx(2), dpToPx(2), dpToPx(2)); + AndroidUtils.setPadding(iconView, dpToPx(2), dpToPx(2), dpToPx(2), dpToPx(2)); baseItemView.addView(iconView); } @@ -957,9 +957,9 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT TextView timeView = new TextView(view.getContext()); FrameLayout.LayoutParams timeViewParams = new FrameLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.WRAP_CONTENT); timeViewParams.gravity = Gravity.END | Gravity.TOP; - timeViewParams.setMargins(0, dpToPx(8), 0, 0); + AndroidUtils.setMargins(timeViewParams,0, dpToPx(8), 0, 0); timeView.setLayoutParams(timeViewParams); - timeView.setPadding(0, 0, dpToPx(16), 0); + AndroidUtils.setPadding(timeView,0, 0, dpToPx(16), 0); timeView.setTextSize(16); timeView.setTextColor(getMainFontColor()); @@ -1008,7 +1008,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT View routeBadge = createRouteBadge(mapActivity, transportStopRoute); LinearLayout.LayoutParams routeBadgeParams = new LinearLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.WRAP_CONTENT); - routeBadgeParams.setMargins(0, dpToPx(6), 0, dpToPx(8)); + AndroidUtils.setMargins(routeBadgeParams, 0, dpToPx(6), 0, dpToPx(8)); routeBadge.setLayoutParams(routeBadgeParams); llText.addView(routeBadge); @@ -1045,13 +1045,13 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT ImageView iconView = new ImageView(view.getContext()); iconView.setImageDrawable(icon); FrameLayout.LayoutParams imageViewLayoutParams = new FrameLayout.LayoutParams(dpToPx(28), dpToPx(28)); - imageViewLayoutParams.gravity = Gravity.TOP; + imageViewLayoutParams.gravity = Gravity.TOP|Gravity.START; iconView.setLayoutParams(imageViewLayoutParams); iconView.setScaleType(ImageView.ScaleType.CENTER_INSIDE); - imageViewLayoutParams.setMargins(dpToPx(14), dpToPx(8), dpToPx(22), 0); + AndroidUtils.setMargins(imageViewLayoutParams, dpToPx(14), dpToPx(8), dpToPx(22), 0); iconView.setBackgroundResource(R.drawable.border_round_solid_light); - iconView.setPadding(dpToPx(2), dpToPx(2), dpToPx(2), dpToPx(2)); + AndroidUtils.setPadding(iconView, dpToPx(2), dpToPx(2), dpToPx(2), dpToPx(2)); baseItemView.addView(iconView); } @@ -1068,9 +1068,9 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT TextView timeView = new TextView(view.getContext()); FrameLayout.LayoutParams timeViewParams = new FrameLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.WRAP_CONTENT); timeViewParams.gravity = Gravity.END | Gravity.TOP; - timeViewParams.setMargins(0, dpToPx(8), 0, 0); + AndroidUtils.setMargins(timeViewParams, 0, dpToPx(8), 0, 0); timeView.setLayoutParams(timeViewParams); - timeView.setPadding(0, 0, dpToPx(16), 0); + AndroidUtils.setPadding(timeView, 0, 0, dpToPx(16), 0); timeView.setTextSize(16); timeView.setTextColor(getMainFontColor()); @@ -1127,16 +1127,16 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT Drawable icon = getPaintedContentIcon(R.drawable.ic_action_pedestrian_dark, getActiveColor()); ImageView iconView = new ImageView(view.getContext()); - iconView.setImageDrawable(icon); + iconView.setImageDrawable(AndroidUtils.getDrawableForDirection(view.getContext(), icon)); FrameLayout.LayoutParams imageViewLayoutParams = new FrameLayout.LayoutParams(dpToPx(24), dpToPx(24)); - imageViewLayoutParams.gravity = imagesContainer != null ? Gravity.TOP : Gravity.CENTER_VERTICAL; + imageViewLayoutParams.gravity = Gravity.START| (imagesContainer != null ? Gravity.TOP : Gravity.CENTER_VERTICAL); iconView.setLayoutParams(imageViewLayoutParams); iconView.setScaleType(ImageView.ScaleType.CENTER_INSIDE); if (imagesContainer != null) { imagesContainer.addView(iconView); } else { - imageViewLayoutParams.setMargins(dpToPx(16), 0, dpToPx(24), 0); + AndroidUtils.setMargins(imageViewLayoutParams, dpToPx(16), 0, dpToPx(24), 0); baseItemView.addView(iconView); } @@ -1183,7 +1183,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT if (imagesContainer != null) { imagesContainer.addView(iconView); } else { - imageViewLayoutParams.setMargins(dpToPx(16), 0, dpToPx(24), 0); + AndroidUtils.setMargins(imageViewLayoutParams, dpToPx(16), 0, dpToPx(24), 0); baseItemView.addView(iconView); } } @@ -1197,9 +1197,9 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT TextView timeView = new TextView(view.getContext()); FrameLayout.LayoutParams timeViewParams = new FrameLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.WRAP_CONTENT); timeViewParams.gravity = Gravity.END | Gravity.TOP; - timeViewParams.setMargins(0, dpToPx(8), 0, 0); + AndroidUtils.setMargins(timeViewParams, 0, dpToPx(8), 0, 0); timeView.setLayoutParams(timeViewParams); - timeView.setPadding(0, 0, dpToPx(16), 0); + AndroidUtils.setPadding(timeView, 0, 0, dpToPx(16), 0); timeView.setTextSize(16); timeView.setTextColor(getMainFontColor()); @@ -1247,7 +1247,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT if (imagesContainer != null) { imagesContainer.addView(iconView); } else { - imageViewLayoutParams.setMargins(dpToPx(16), 0, dpToPx(24), 0); + AndroidUtils.setMargins(imageViewLayoutParams, dpToPx(16), 0, dpToPx(24), 0); baseItemView.addView(iconView); } @@ -1271,9 +1271,9 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT TextView timeView = new TextView(view.getContext()); FrameLayout.LayoutParams timeViewParams = new FrameLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.WRAP_CONTENT); timeViewParams.gravity = Gravity.END | Gravity.TOP; - timeViewParams.setMargins(0, dpToPx(8), 0, 0); + AndroidUtils.setMargins(timeViewParams, 0, dpToPx(8), 0, 0); timeView.setLayoutParams(timeViewParams); - timeView.setPadding(0, 0, dpToPx(16), 0); + AndroidUtils.setPadding(timeView, 0, 0, dpToPx(16), 0); timeView.setTextSize(16); timeView.setTextColor(getMainFontColor()); @@ -1315,13 +1315,13 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT ImageView iconView = new ImageView(view.getContext()); iconView.setImageDrawable(icon); FrameLayout.LayoutParams imageViewLayoutParams = new FrameLayout.LayoutParams(dpToPx(22), dpToPx(22)); - imageViewLayoutParams.gravity = Gravity.CENTER_VERTICAL; + imageViewLayoutParams.gravity = Gravity.CENTER_VERTICAL | Gravity.START; iconView.setLayoutParams(imageViewLayoutParams); iconView.setScaleType(ImageView.ScaleType.CENTER_INSIDE); - imageViewLayoutParams.setMargins(dpToPx(17), 0, dpToPx(25), 0); + AndroidUtils.setMargins(imageViewLayoutParams, dpToPx(17), 0, dpToPx(25), 0); iconView.setBackgroundResource(R.drawable.border_round_solid_light_small); - iconView.setPadding(dpToPx(2), dpToPx(2), dpToPx(2), dpToPx(2)); + AndroidUtils.setPadding(iconView, dpToPx(2), dpToPx(2), dpToPx(2), dpToPx(2)); baseItemView.addView(iconView); } @@ -1366,7 +1366,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT OsmandApplication app = requireMyApplication(); TextViewEx titleView = new TextViewEx(container.getContext()); FrameLayout.LayoutParams titleParams = new FrameLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT); - titleParams.gravity = Gravity.CENTER_VERTICAL; + titleParams.gravity = Gravity.CENTER_VERTICAL | Gravity.START; titleView.setTypeface(FontCache.getRobotoRegular(container.getContext())); titleView.setLayoutParams(titleParams); titleView.setTextSize(16); @@ -1380,7 +1380,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT OsmandApplication app = requireMyApplication(); TextViewEx textViewDescription = new TextViewEx(container.getContext()); LinearLayout.LayoutParams descriptionParams = new LinearLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT); - descriptionParams.setMargins(0, dpToPx(paddingTop), 0, dpToPx(paddingBottom)); + AndroidUtils.setMargins(descriptionParams, 0, dpToPx(paddingTop), 0, dpToPx(paddingBottom)); textViewDescription.setLayoutParams(descriptionParams); textViewDescription.setTypeface(FontCache.getRobotoRegular(container.getContext())); textViewDescription.setTextSize(14); @@ -1394,7 +1394,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT llText.setOrientation(LinearLayout.VERTICAL); LinearLayout.LayoutParams llTextViewParams = new LinearLayout.LayoutParams(0, ViewGroup.LayoutParams.WRAP_CONTENT); llTextViewParams.weight = 1f; - llTextViewParams.gravity = Gravity.CENTER_VERTICAL; + llTextViewParams.gravity = Gravity.CENTER_VERTICAL | Gravity.START; llText.setLayoutParams(llTextViewParams); return llText; } @@ -1406,7 +1406,7 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT ll.setMinimumHeight(dpToPx(minHeight)); ll.setLayoutParams(llParams); ll.setBackgroundResource(AndroidUtils.resolveAttribute(context, android.R.attr.selectableItemBackground)); - ll.setPadding(dpToPx(64f), 0, dpToPx(16f), 0); + AndroidUtils.setPadding(ll, dpToPx(64f), 0, dpToPx(16f), 0); ll.setOnLongClickListener(onLongClickListener); return ll; } @@ -1471,9 +1471,9 @@ public class RouteDetailsFragment extends ContextMenuFragment implements PublicT OsmandApplication app = requireMyApplication(); View horizontalLine = new View(view.getContext()); LinearLayout.LayoutParams llHorLineParams = new LinearLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, dpToPx(1f)); - llHorLineParams.gravity = Gravity.BOTTOM; + llHorLineParams.gravity = Gravity.BOTTOM | Gravity.START; if (needMargin) { - llHorLineParams.setMargins(dpToPx(64), 0, 0, 0); + AndroidUtils.setMargins(llHorLineParams, dpToPx(64), 0, 0, 0); } horizontalLine.setLayoutParams(llHorLineParams); horizontalLine.setBackgroundColor(ContextCompat.getColor(app, isNightMode() ? R.color.divider_color_dark : R.color.divider_color_light)); diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java index 27918a081e..c54ec92285 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java @@ -168,7 +168,7 @@ public class WaypointsFragment extends BaseOsmAndFragment implements ObservableS int width = getResources().getDimensionPixelSize(R.dimen.dashboard_land_width) - getResources().getDimensionPixelSize(R.dimen.dashboard_land_shadow_width); FrameLayout.LayoutParams params = new FrameLayout.LayoutParams(width, ViewGroup.LayoutParams.WRAP_CONTENT); - params.gravity = Gravity.BOTTOM; + params.gravity = Gravity.BOTTOM|Gravity.START; view.findViewById(R.id.control_buttons).setLayoutParams(params); } diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/cards/PublicTransportCard.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/cards/PublicTransportCard.java index c0deef7a6b..c75c522219 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/cards/PublicTransportCard.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/cards/PublicTransportCard.java @@ -1,6 +1,7 @@ package net.osmand.plus.routepreparationmenu.cards; import android.graphics.Typeface; +import android.graphics.drawable.Drawable; import android.graphics.drawable.GradientDrawable; import android.os.Build; import android.text.SpannableString; @@ -389,7 +390,8 @@ public class PublicTransportCard extends BaseCard { TextView transportStopRouteTextView = (TextView) bageView.findViewById(R.id.transport_stop_route_text); ImageView transportStopRouteImageView = (ImageView) bageView.findViewById(R.id.transport_stop_route_icon); - transportStopRouteImageView.setImageDrawable(getActiveIcon(R.drawable.ic_action_pedestrian_dark)); + Drawable icPedestrian = getActiveIcon(R.drawable.ic_action_pedestrian_dark); + transportStopRouteImageView.setImageDrawable(AndroidUtils.getDrawableForDirection(app, icPedestrian)); transportStopRouteTextView.setText(OsmAndFormatter.getFormattedDuration((int) walkTime, app)); GradientDrawable gradientDrawableBg = (GradientDrawable) bageView.getBackground(); gradientDrawableBg.setColor(activeColor); @@ -413,7 +415,8 @@ public class PublicTransportCard extends BaseCard { private View createArrow() { LinearLayout container = new LinearLayout(app); ImageView arrow = new ImageView(app); - arrow.setImageDrawable(getContentIcon(R.drawable.ic_action_arrow_forward_16)); + Drawable icArrow = getContentIcon(R.drawable.ic_action_arrow_forward_16); + arrow.setImageDrawable(AndroidUtils.getDrawableForDirection(app, icArrow)); container.addView(arrow, new LinearLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, AndroidUtils.dpToPx(app, 28))); return container; } diff --git a/OsmAnd/src/net/osmand/plus/views/OsmandMapTileView.java b/OsmAnd/src/net/osmand/plus/views/OsmandMapTileView.java index 1f4f32c4c2..af1e61053f 100644 --- a/OsmAnd/src/net/osmand/plus/views/OsmandMapTileView.java +++ b/OsmAnd/src/net/osmand/plus/views/OsmandMapTileView.java @@ -28,6 +28,7 @@ import android.view.View; import android.view.WindowManager; import android.widget.Toast; +import net.osmand.AndroidUtils; import net.osmand.PlatformUtil; import net.osmand.access.AccessibilityActionsProvider; import net.osmand.core.android.MapRendererView; @@ -632,7 +633,8 @@ public class OsmandMapTileView implements IMapDownloaderCallback { } else if (mapPosition == OsmandSettings.LANDSCAPE_MIDDLE_RIGHT_CONSTANT) { ratiox = 0.7f; } else { - ratiox = mapPositionX == 0 ? 0.5f : 0.75f; + boolean isLayoutRtl = AndroidUtils.isLayoutRtl(application); + ratiox = mapPositionX == 0 ? 0.5f : (isLayoutRtl ? 0.25f : 0.75f); } final int cy = (int) (ratioy * view.getHeight()); final int cx = (int) (ratiox * view.getWidth()); diff --git a/OsmAnd/src/net/osmand/plus/widgets/FlowLayout.java b/OsmAnd/src/net/osmand/plus/widgets/FlowLayout.java index c59ebb37fa..63a43e56ad 100644 --- a/OsmAnd/src/net/osmand/plus/widgets/FlowLayout.java +++ b/OsmAnd/src/net/osmand/plus/widgets/FlowLayout.java @@ -6,10 +6,11 @@ import android.util.AttributeSet; import android.view.View; import android.view.ViewGroup; +import net.osmand.AndroidUtils; + public class FlowLayout extends ViewGroup { private int line_height; - private boolean rtl = false; public static class LayoutParams extends ViewGroup.LayoutParams { @@ -91,12 +92,10 @@ public class FlowLayout extends ViewGroup { @Override protected void onLayout(boolean changed, int l, int t, int r, int b) { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { - rtl = getLayoutDirection() == LAYOUT_DIRECTION_RTL; - } final int count = getChildCount(); final int width = r - l; - int xpos = rtl ? width - getPaddingRight() : getPaddingLeft(); + boolean isLayoutRtl = AndroidUtils.isLayoutRtl(getContext()); + int xpos = isLayoutRtl ? width - getPaddingRight() : getPaddingLeft(); int ypos = getPaddingTop(); for (int i = 0; i < count; i++) { final View child = getChildAt(i); @@ -104,13 +103,13 @@ public class FlowLayout extends ViewGroup { final int childw = child.getMeasuredWidth(); final int childh = child.getMeasuredHeight(); final LayoutParams lp = (LayoutParams) child.getLayoutParams(); - if (rtl) { + if (isLayoutRtl) { if (xpos - childw < l) { xpos = width - getPaddingRight(); ypos += line_height; } child.layout(xpos - childw, ypos, xpos, ypos + childh); - xpos -= childw - lp.horizontal_spacing; + xpos -= childw + lp.horizontal_spacing; } else { if (xpos + childw > width) { xpos = getPaddingLeft(); From 1a9fc81220c526614329c8641d000dcdf24f9d6d Mon Sep 17 00:00:00 2001 From: Nazar-Kutz Date: Tue, 28 Apr 2020 10:54:54 +0300 Subject: [PATCH 2/7] Fix content Insets (RTL) --- .../layout-land/fragment_direction_indication_dialog.xml | 4 +++- OsmAnd/res/layout-land/fragment_plan_route_half_screen.xml | 4 +++- OsmAnd/res/layout-land/point_editor_fragment.xml | 4 +++- OsmAnd/res/layout/bottom_sheet_item_toolbar_title.xml | 4 +++- OsmAnd/res/layout/dashboard_toolbar.xml | 4 +++- OsmAnd/res/layout/fragment_direction_indication_dialog.xml | 4 +++- OsmAnd/res/layout/fragment_edit_poi.xml | 4 +++- OsmAnd/res/layout/fragment_map_markers_dialog.xml | 4 +++- OsmAnd/res/layout/fragment_wikivoyage_article_dialog.xml | 4 +++- OsmAnd/res/layout/global_preference_toolbar.xml | 4 +++- .../res/layout/global_preferences_toolbar_with_switch.xml | 4 +++- OsmAnd/res/layout/item_info_fragment.xml | 4 +++- OsmAnd/res/layout/map_context_menu_fragment.xml | 4 +++- OsmAnd/res/layout/maps_in_category_fragment.xml | 3 ++- OsmAnd/res/layout/plan_route_toolbar_and_up_down_row.xml | 2 ++ OsmAnd/res/layout/point_editor_fragment.xml | 4 +++- OsmAnd/res/layout/profile_preference_toolbar.xml | 2 ++ OsmAnd/res/layout/profile_preference_toolbar_big.xml | 2 ++ OsmAnd/res/layout/profile_preference_toolbar_with_icon.xml | 4 +++- .../res/layout/profile_preference_toolbar_with_switch.xml | 2 ++ OsmAnd/res/layout/quick_action_create_edit_dialog.xml | 2 ++ OsmAnd/res/layout/search_advanced_coords.xml | 4 +++- OsmAnd/res/layout/search_custom_poi.xml | 4 +++- OsmAnd/res/layout/search_dialog_fragment.xml | 6 +++++- OsmAnd/res/layout/search_favs_fragment.xml | 4 +++- OsmAnd/res/layout/search_poi_filter.xml | 4 +++- OsmAnd/res/layout/split_segments_layout.xml | 4 +++- OsmAnd/res/layout/tab_content.xml | 2 ++ OsmAnd/res/layout/wikipedia_dialog_fragment.xml | 4 +++- OsmAnd/res/layout/wikivoyage_explore.xml | 4 +++- 30 files changed, 85 insertions(+), 24 deletions(-) diff --git a/OsmAnd/res/layout-land/fragment_direction_indication_dialog.xml b/OsmAnd/res/layout-land/fragment_direction_indication_dialog.xml index 4463a2d1a6..ab5e850dd8 100644 --- a/OsmAnd/res/layout-land/fragment_direction_indication_dialog.xml +++ b/OsmAnd/res/layout-land/fragment_direction_indication_dialog.xml @@ -20,7 +20,9 @@ android:layout_height="@dimen/dashboard_map_toolbar" android:minHeight="@dimen/dashboard_map_toolbar" app:contentInsetLeft="54dp" - app:contentInsetStart="54dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="72dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> diff --git a/OsmAnd/res/layout/bottom_sheet_item_toolbar_title.xml b/OsmAnd/res/layout/bottom_sheet_item_toolbar_title.xml index dfc6c95148..c4cc113ff6 100644 --- a/OsmAnd/res/layout/bottom_sheet_item_toolbar_title.xml +++ b/OsmAnd/res/layout/bottom_sheet_item_toolbar_title.xml @@ -7,7 +7,9 @@ android:layout_height="@dimen/bottom_sheet_selected_item_title_height" android:minHeight="@dimen/bottom_sheet_selected_item_title_height" osmand:contentInsetLeft="54dp" - osmand:contentInsetStart="54dp"> + osmand:contentInsetStart="54dp" + osmand:contentInsetRight="0dp" + osmand:contentInsetEnd="0dp"> + app:contentInsetStart="4dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="@dimen/settings_divider_margin_start" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"/> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + osmand:contentInsetStart="54dp" + osmand:contentInsetRight="0dp" + osmand:contentInsetEnd="0dp"> + app:contentInsetStart="0dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="0dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="72dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp" /> diff --git a/OsmAnd/res/layout/map_context_menu_fragment.xml b/OsmAnd/res/layout/map_context_menu_fragment.xml index 6089fbc5e2..6c87325935 100644 --- a/OsmAnd/res/layout/map_context_menu_fragment.xml +++ b/OsmAnd/res/layout/map_context_menu_fragment.xml @@ -548,7 +548,9 @@ android:layout_height="@dimen/dashboard_map_toolbar" android:background="@color/app_bar_color_light" app:contentInsetLeft="4dp" - app:contentInsetStart="4dp"> + app:contentInsetStart="4dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"/> + app:contentInsetStart="72dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> diff --git a/OsmAnd/res/layout/profile_preference_toolbar.xml b/OsmAnd/res/layout/profile_preference_toolbar.xml index 45e7db5c82..e007045d41 100644 --- a/OsmAnd/res/layout/profile_preference_toolbar.xml +++ b/OsmAnd/res/layout/profile_preference_toolbar.xml @@ -7,6 +7,8 @@ android:minHeight="@dimen/dashboard_map_toolbar" osmand:contentInsetLeft="0dp" osmand:contentInsetStart="0dp" + osmand:contentInsetRight="0dp" + osmand:contentInsetEnd="0dp" osmand:theme="@style/ThemeOverlay.AppCompat.ActionBar"> + osmand:contentInsetStart="0dp" + osmand:contentInsetRight="0dp" + osmand:contentInsetEnd="0dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> @@ -40,6 +42,8 @@ android:visibility="gone" app:contentInsetLeft="54dp" app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp" tools:visibility="visible"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> diff --git a/OsmAnd/res/layout/search_poi_filter.xml b/OsmAnd/res/layout/search_poi_filter.xml index 256ae6ee9b..071ff9724a 100644 --- a/OsmAnd/res/layout/search_poi_filter.xml +++ b/OsmAnd/res/layout/search_poi_filter.xml @@ -18,7 +18,9 @@ android:minHeight="@dimen/dashboard_map_toolbar" android:theme="?attr/toolbar_theme" app:contentInsetLeft="54dp" - app:contentInsetStart="54dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> diff --git a/OsmAnd/res/layout/wikipedia_dialog_fragment.xml b/OsmAnd/res/layout/wikipedia_dialog_fragment.xml index dbc5444ea2..37429ac0eb 100644 --- a/OsmAnd/res/layout/wikipedia_dialog_fragment.xml +++ b/OsmAnd/res/layout/wikipedia_dialog_fragment.xml @@ -17,7 +17,9 @@ android:gravity="center_vertical" android:minHeight="@dimen/toolbar_height" osmand:contentInsetLeft="54dp" - osmand:contentInsetStart="54dp"> + osmand:contentInsetStart="54dp" + osmand:contentInsetRight="0dp" + osmand:contentInsetEnd="0dp"> + osmand:contentInsetStart="54dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> Date: Tue, 28 Apr 2020 12:54:40 +0300 Subject: [PATCH 3/7] Fix back arrow (RTL) --- .../net/osmand/plus/chooseplan/ChoosePlanDialogFragment.java | 5 ++++- .../net/osmand/plus/dialogs/HelpArticleDialogFragment.java | 2 ++ .../net/osmand/plus/settings/ConfigureMenuItemsFragment.java | 4 +++- .../net/osmand/plus/settings/ConfigureMenuRootFragment.java | 4 +++- .../net/osmand/plus/settings/ImportDuplicatesFragment.java | 3 ++- 5 files changed, 14 insertions(+), 4 deletions(-) diff --git a/OsmAnd/src/net/osmand/plus/chooseplan/ChoosePlanDialogFragment.java b/OsmAnd/src/net/osmand/plus/chooseplan/ChoosePlanDialogFragment.java index cba81e6113..c4290f8355 100644 --- a/OsmAnd/src/net/osmand/plus/chooseplan/ChoosePlanDialogFragment.java +++ b/OsmAnd/src/net/osmand/plus/chooseplan/ChoosePlanDialogFragment.java @@ -16,6 +16,7 @@ import android.view.View; import android.view.View.OnClickListener; import android.view.ViewGroup; import android.view.Window; +import android.widget.ImageView; import android.widget.LinearLayout; import android.widget.ProgressBar; import android.widget.TextView; @@ -187,7 +188,9 @@ public abstract class ChoosePlanDialogFragment extends BaseOsmAndDialogFragment } View view = inflate(R.layout.purchase_dialog_fragment, container); - view.findViewById(R.id.button_back).setOnClickListener(new OnClickListener() { + ImageView buttonBack = view.findViewById(R.id.button_back); + buttonBack.setImageResource(AndroidUtils.getNavigationIconResId(ctx)); + buttonBack.setOnClickListener(new OnClickListener() { @Override public void onClick(View v) { dismiss(); diff --git a/OsmAnd/src/net/osmand/plus/dialogs/HelpArticleDialogFragment.java b/OsmAnd/src/net/osmand/plus/dialogs/HelpArticleDialogFragment.java index 996ed1e80f..06a272263d 100644 --- a/OsmAnd/src/net/osmand/plus/dialogs/HelpArticleDialogFragment.java +++ b/OsmAnd/src/net/osmand/plus/dialogs/HelpArticleDialogFragment.java @@ -14,6 +14,7 @@ import androidx.annotation.NonNull; import androidx.appcompat.widget.Toolbar; import androidx.fragment.app.DialogFragment; +import net.osmand.AndroidUtils; import net.osmand.PlatformUtil; import net.osmand.plus.OsmandApplication; import net.osmand.plus.OsmandSettings; @@ -58,6 +59,7 @@ public class HelpArticleDialogFragment extends DialogFragment { final View view = inflater.inflate(R.layout.fragment_help_article, container, false); Toolbar toolbar = (Toolbar) view.findViewById(R.id.toolbar); + toolbar.setNavigationIcon(AndroidUtils.getNavigationIconResId(getContext())); toolbar.setNavigationContentDescription(R.string.access_shared_string_navigate_up); toolbar.setNavigationOnClickListener(new View.OnClickListener() { @Override diff --git a/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuItemsFragment.java b/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuItemsFragment.java index 6777b95add..84cc47dfde 100644 --- a/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuItemsFragment.java +++ b/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuItemsFragment.java @@ -187,7 +187,9 @@ public class ConfigureMenuItemsFragment extends BaseOsmAndFragment toolbarTitle.setTextColor(nightMode ? getResources().getColor(R.color.text_color_primary_dark) : getResources().getColor(R.color.list_background_color_dark)); - toolbarButton.setImageDrawable(getPaintedContentIcon(R.drawable.ic_arrow_back, getResources().getColor(R.color.text_color_secondary_light))); + toolbarButton.setImageDrawable(getPaintedContentIcon( + AndroidUtils.getNavigationIconResId(app), + getResources().getColor(R.color.text_color_secondary_light))); toolbarTitle.setText(screenType.titleRes); toolbarButton.setOnClickListener(new View.OnClickListener() { @Override diff --git a/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuRootFragment.java b/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuRootFragment.java index a45a72dc11..3588f6af27 100644 --- a/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuRootFragment.java +++ b/OsmAnd/src/net/osmand/plus/settings/ConfigureMenuRootFragment.java @@ -103,7 +103,9 @@ public class ConfigureMenuRootFragment extends BaseOsmAndFragment { ? getResources().getColor(R.color.text_color_primary_dark) : getResources().getColor(R.color.list_background_color_dark)); toolbarSubTitle.setTextColor(getResources().getColor(R.color.text_color_secondary_light)); - toolbarButton.setImageDrawable(getPaintedContentIcon(R.drawable.ic_arrow_back, getResources().getColor(R.color.text_color_secondary_light))); + toolbarButton.setImageDrawable(getPaintedContentIcon( + AndroidUtils.getNavigationIconResId(app), + getResources().getColor(R.color.text_color_secondary_light))); toolbarButton.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View view) { diff --git a/OsmAnd/src/net/osmand/plus/settings/ImportDuplicatesFragment.java b/OsmAnd/src/net/osmand/plus/settings/ImportDuplicatesFragment.java index 08f9346c21..388dbb699d 100644 --- a/OsmAnd/src/net/osmand/plus/settings/ImportDuplicatesFragment.java +++ b/OsmAnd/src/net/osmand/plus/settings/ImportDuplicatesFragment.java @@ -287,7 +287,8 @@ public class ImportDuplicatesFragment extends BaseOsmAndFragment implements View private void setupToolbar(Toolbar toolbar) { toolbar.setTitle(R.string.import_duplicates_title); - toolbar.setNavigationIcon(getPaintedContentIcon(R.drawable.ic_arrow_back, + toolbar.setNavigationIcon(getPaintedContentIcon( + AndroidUtils.getNavigationIconResId(app), nightMode ? getResources().getColor(R.color.active_buttons_and_links_text_dark) : getResources().getColor(R.color.active_buttons_and_links_text_light))); From 779a09e31299804c6371c7cae269286ec50058bb Mon Sep 17 00:00:00 2001 From: Nazar-Kutz Date: Wed, 29 Apr 2020 12:21:12 +0300 Subject: [PATCH 4/7] Back Arrow fix (RTL) --- OsmAnd/res/drawable-hdpi/ic_action_mode_back.png | Bin 667 -> 0 bytes .../res/drawable-xhdpi/ic_action_mode_back.png | Bin 706 -> 0 bytes .../res/drawable-xxhdpi/ic_action_mode_back.png | Bin 924 -> 0 bytes .../res/drawable-xxxhdpi/ic_action_mode_back.png | Bin 1437 -> 0 bytes OsmAnd/res/layout/fragment_simple_list.xml | 2 +- OsmAnd/res/layout/global_preference_toolbar.xml | 2 +- .../global_preferences_toolbar_with_switch.xml | 2 +- .../res/layout/map_marker_selection_fragment.xml | 2 +- OsmAnd/res/layout/profile_preference_toolbar.xml | 2 +- .../layout/profile_preference_toolbar_big.xml | 2 +- .../profile_preference_toolbar_with_icon.xml | 2 +- .../profile_preference_toolbar_with_switch.xml | 2 +- OsmAnd/res/values/styles.xml | 4 ++-- .../plus/liveupdates/SubscriptionFragment.java | 6 ++++-- .../controllers/TransportRouteController.java | 13 +++++++++++-- .../mapmarkers/MapMarkerSelectionFragment.java | 4 +++- .../plus/mapmarkers/PlanRouteFragment.java | 3 ++- .../measurementtool/MeasurementToolFragment.java | 9 ++++++--- 18 files changed, 36 insertions(+), 19 deletions(-) delete mode 100644 OsmAnd/res/drawable-hdpi/ic_action_mode_back.png delete mode 100644 OsmAnd/res/drawable-xhdpi/ic_action_mode_back.png delete mode 100644 OsmAnd/res/drawable-xxhdpi/ic_action_mode_back.png delete mode 100644 OsmAnd/res/drawable-xxxhdpi/ic_action_mode_back.png diff --git a/OsmAnd/res/drawable-hdpi/ic_action_mode_back.png b/OsmAnd/res/drawable-hdpi/ic_action_mode_back.png deleted file mode 100644 index 6c36eae2f4aee9ca8665b7436f3317042e6dcc97..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 667 zcmeAS@N?(olHy`uVBq!ia0vp^Dj>|k1|%Oc%$NbBSkfJR9T^xl_H+M9WCijWi-X*q z7}lMWc?skwBzpw;GB8xBF)%c=FfjZA3N^f7U???UV0e|lz+eS5K)hhiu0R{01Y44~ zy9>jA5L~c#`DCC7XMsm#F_88EW4Dvpc0l8^JzX3_A`ZWuaWLqRfr#sQZH;$-Vq>>j z7d-vJ_>bA@asAG~kSVVhCH6F4GFzHC^WoW)7gJQ`+?oAE^?;?H&KmDz&)?Qtf8;HW zt}=M`RXKdo!cEE=$p?;!u3m9@zEh)-Ef&BFrnYw4D zZ=aRMSN2S;__otqg+E^Nj9eK$-&nEv#Er;#@7#Ng)So&q)-VSru-;+LKOp*4@9rsv z1g1UA{0G<*(zey79ITmP?RssJnU!D8@5-qqd-Km*O^Fd!S$ucKKV<{wOJ>>kEj&NZ z)A_w-y={|cEl1Xm)Obcwt*K?nYXY-oT)B8*-t|3w<}Au$8PZ+mA3PN+pk}YUF!Zl{jjBlzt{7+P2vnp&9}0=ZTO23Ho$jzZCp zo1c=IR*74~(!a{jfEpx0HU#IVm6RtIr7}3CNS%G}U;vjb? zhIQv;UIIA^$sR$z3=CCj3=9n|3=F@3LJcn%7)pVryh>nTu$sZZAYL$MSD+10f-TA0 z-G$*l2rk&Wd@@jkv%n*=7)X17vD?XPJD~BCJY5_^GVZ;d>F9UZK)`jr^XVp4q4ozH z9tZle75W@^El73FKO$|&g-g0nMMiEEFTx)Qq-|I_I5 zxa!+GwmvWxjLevm6@5ukSoFbkDSy`|tAg3G4*0t~sgZwB9cSNc{-d^SzrhdLL+NsV zmTvq0^;g8xeEvmDf4m-x3tDDp&wroW6fW9%lS_h0xmUKb=o?!Mv;P6Z32VRJ4`Vu` z>B(Tetc5FZ$w9lCM_;2E)*qO-?I_E8=HLe+GoJo=cYU(v>_(ao;KA}cRW&+duEuXp0eyBScYPMk;hwy{Ah3$W0j(9&{t2h#U zWMc1`y*u2_e=xJ+%2|9qH*fLnSuftTuW9Rir&gGD$Y%zp@y5JI_iNR6Rc{DA>{7VJ z;>D6iE;Sb^n>)F`Dr(o1YVyjizb!8#>T^M4&&d>{t?T_6qV}zE5|W+;j3(6**NBpo z#FA92!lvI6;x#X;^) z4C~IxyaaL-l0AZa85pY67#JE_7#My5g&JNkFq9fFFuY1&V6d9Oz#v{QXIG#NP=YPV z+ueoXKL{?^yL>WGgtNdSvKUB%?PPE}nQh0wz?9?Z;uunK>+S4|ezy%ITKj`1sBO6& z`&Nweo6YWgUK1zO-dK1Lv&G-T&17J6*bQYsKVeHIqV5`$m1A+&}vWr$UQ> z6NloF2*sbjUcF9MnDVYcSdd{uEdRnB@$S0n{yFBks;Z$&_w7(sm)f!IQ~2+QN88LF z#W)*HShHqd%Hd15v~H)_O^PaV@;=uss?WJu@QQKKHMJ#qqLcP0{xm$LbN9bcQJ7j% zvg)Ut_1jhKW%n#-jL5yy(P^lB(t6VJy#1H#ll6;!CAq41tJF`hDHr~lc+PR=#;U@i zb2+z<#ynYa?A5)aS!K%V>S6B1lNU#no(No12E;;7G{R(yL{@_^i)B}6yUfw7_BmG~ z{;K?3D!V!;^*+!{QP-cFKLt*a=_`67@o|?AZvy9oORxUjGFtnO;em8RJcHkzvZV?Q z%jd{Wvd(T=)FO4@7E9srbX(>MmJf^vmMxfZLb&0)V$1O>vXk5cyw9C_a^+jx{Z}V8 zPTjcS#9c*qfweJ=KlSA!F)tG5(>4+Q%yf3eEUx!*h6&o4 zy>4MsOs0DNy311O$#}c7DtS}Zb-C@_40X&uxE`ES@qL$X_x|$i=C!9}HR8U_Ns>9z z_-Mb!Dch?R#ccHxnyge_rj$AadEI$dx^uDfB)u7`UO{)*R5bHACy8u#@$9&u2yYo&u(h7J;Oy zKa5$j(g$lko!S9RgsLU35hW>!C8<`)MX5lF!N|bSMAyJv*T^`;(89{l)XLNl$h9&s zxUyh&6pDu2{FKbJO57Tj{#AYk)F276Aviy+q&%@GmBBG3KPgqgGdD3kH7GSPrLyp3 RDkzsQc)I$ztaD0e0swE)fB^si diff --git a/OsmAnd/res/drawable-xxxhdpi/ic_action_mode_back.png b/OsmAnd/res/drawable-xxxhdpi/ic_action_mode_back.png deleted file mode 100644 index 70c2040210887f654dfea3b13ca7758424c5f070..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1437 zcmbVLeM}o=7=H_uGz?6mI00EWOP0W9dmsI}yV22)Ye$`B2+d%bQLfhmE^v3<^;ipz zK#*l2nL?IM_|J-q#>8kAV@S4u!XFz#{KG|@*4U z8jvj$wasDJPO33bi+E&(N315Rk;4cau~R18YN2ra6@XPzF;mQJl9d(|rzi@=2$Ud<(83t)lvFlul%i!B4-6mW z6d|GtvV^2OvLU%cbr@i#+a-vRKw!tQ6ipKaDMRCI1jS7lDvGJPwydLS9sh3{yIMzs zoe>_bSr7V_{S6$!n7G9yoAN< z_L2l)BXJxGm&Z%GyqMKYVVEW3V>c}BB5jn}OJbCb!Evv}ZS&wBi;p2Z9?a^tkQuCB zimI%{@tL>+jGM;VpNgeD3eT#t5|rik%mmc7%Bmb~l_QA9gOmqYPLNW1MXEpBatG0Y!y*X@ApQF6w)cyIBx_dK&xsOWS z)2n059Y^=XZ* + android:src="@drawable/ic_arrow_back"/> + android:src="@drawable/ic_arrow_back" /> + android:src="@drawable/ic_arrow_back" /> + android:src="@drawable/ic_arrow_back"/> @drawable/context_menu_controller_text_color_light @color/ctx_menu_buttons_divider_light @color/activity_background_color_dark - @drawable/ic_action_mode_back + @drawable/ic_arrow_back @style/WhiteActionMode @color/color_white @drawable/switch_ex_background_light @@ -196,7 +196,7 @@ @color/app_bar_color_light @style/Widget.Styled.ActionBarLight - @drawable/ic_action_mode_back + @drawable/ic_arrow_back @style/WhiteActionMode @color/color_white @style/OverflowMenuButton diff --git a/OsmAnd/src/net/osmand/plus/liveupdates/SubscriptionFragment.java b/OsmAnd/src/net/osmand/plus/liveupdates/SubscriptionFragment.java index c51e62c988..7f8b0e4abc 100644 --- a/OsmAnd/src/net/osmand/plus/liveupdates/SubscriptionFragment.java +++ b/OsmAnd/src/net/osmand/plus/liveupdates/SubscriptionFragment.java @@ -2,6 +2,7 @@ package net.osmand.plus.liveupdates; import android.app.Activity; import android.app.ProgressDialog; +import android.graphics.drawable.Drawable; import android.os.Bundle; import android.view.LayoutInflater; import android.view.MotionEvent; @@ -98,7 +99,7 @@ public class SubscriptionFragment extends BaseOsmAndDialogFragment implements In @Override public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { - + OsmandApplication app = getMyApplication(); String userName = settings.BILLING_USER_NAME.get(); String email = settings.BILLING_USER_EMAIL.get(); String countryDownloadName = settings.BILLING_USER_COUNTRY_DOWNLOAD_NAME.get(); @@ -122,7 +123,8 @@ public class SubscriptionFragment extends BaseOsmAndDialogFragment implements In View view = inflater.inflate(R.layout.subscription_fragment, container, false); ImageButton closeButton = (ImageButton) view.findViewById(R.id.closeButton); - closeButton.setImageDrawable(getMyApplication().getUIUtilities().getIcon(R.drawable.ic_action_mode_back)); + Drawable icBack = app.getUIUtilities().getIcon(AndroidUtils.getNavigationIconResId(app)); + closeButton.setImageDrawable(icBack); closeButton.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { diff --git a/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/TransportRouteController.java b/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/TransportRouteController.java index 0b08118495..585ba61f62 100644 --- a/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/TransportRouteController.java +++ b/OsmAnd/src/net/osmand/plus/mapcontextmenu/controllers/TransportRouteController.java @@ -6,6 +6,7 @@ import android.view.View.OnClickListener; import androidx.annotation.NonNull; +import net.osmand.AndroidUtils; import net.osmand.binary.OsmandOdb.TransportRouteStop; import net.osmand.data.LatLon; import net.osmand.data.PointDescription; @@ -29,8 +30,10 @@ public class TransportRouteController extends MenuController { super(new MenuBuilder(mapActivity), pointDescription, mapActivity); this.transportRoute = transportRoute; builder.setShowOnlinePhotos(false); + int navigationIconResId = AndroidUtils.getNavigationIconResId(mapActivity); toolbarController = new ContextMenuToolbarController(this); toolbarController.setTitle(getNameStr()); + toolbarController.setBackBtnIconIds(navigationIconResId, navigationIconResId); toolbarController.setOnBackButtonClickListener(new OnClickListener() { @Override public void onClick(View v) { @@ -66,7 +69,6 @@ public class TransportRouteController extends MenuController { } }; leftTitleButtonController.caption = mapActivity.getString(R.string.shared_string_previous); - leftTitleButtonController.leftIconId = R.drawable.ic_arrow_back; rightTitleButtonController = new TitleButtonController() { @Override @@ -78,7 +80,14 @@ public class TransportRouteController extends MenuController { } }; rightTitleButtonController.caption = mapActivity.getString(R.string.shared_string_next); - rightTitleButtonController.rightIconId = R.drawable.ic_arrow_forward; + + if (AndroidUtils.isLayoutRtl(mapActivity)) { + leftTitleButtonController.rightIconId = R.drawable.ic_arrow_forward; + rightTitleButtonController.leftIconId = R.drawable.ic_arrow_back; + } else { + leftTitleButtonController.leftIconId = R.drawable.ic_arrow_back; + rightTitleButtonController.rightIconId = R.drawable.ic_arrow_forward; + } } @NonNull diff --git a/OsmAnd/src/net/osmand/plus/mapmarkers/MapMarkerSelectionFragment.java b/OsmAnd/src/net/osmand/plus/mapmarkers/MapMarkerSelectionFragment.java index fd63e7bd3e..993c5c1d93 100644 --- a/OsmAnd/src/net/osmand/plus/mapmarkers/MapMarkerSelectionFragment.java +++ b/OsmAnd/src/net/osmand/plus/mapmarkers/MapMarkerSelectionFragment.java @@ -1,6 +1,7 @@ package net.osmand.plus.mapmarkers; import android.content.Context; +import android.graphics.drawable.Drawable; import android.os.Bundle; import android.view.LayoutInflater; import android.view.View; @@ -81,7 +82,8 @@ public class MapMarkerSelectionFragment extends BaseOsmAndDialogFragment { View view = inflater.inflate(R.layout.map_marker_selection_fragment, container, false); ImageButton closeButton = (ImageButton) view.findViewById(R.id.closeButton); - closeButton.setImageDrawable(getMyApplication().getUIUtilities().getIcon(R.drawable.ic_action_mode_back)); + Drawable icBack = app.getUIUtilities().getIcon(AndroidUtils.getNavigationIconResId(app)); + closeButton.setImageDrawable(icBack); closeButton.setOnClickListener(new View.OnClickListener() { @Override public void onClick(View v) { diff --git a/OsmAnd/src/net/osmand/plus/mapmarkers/PlanRouteFragment.java b/OsmAnd/src/net/osmand/plus/mapmarkers/PlanRouteFragment.java index 6c23918c90..6446258faa 100644 --- a/OsmAnd/src/net/osmand/plus/mapmarkers/PlanRouteFragment.java +++ b/OsmAnd/src/net/osmand/plus/mapmarkers/PlanRouteFragment.java @@ -200,8 +200,9 @@ public class PlanRouteFragment extends BaseOsmAndFragment implements OsmAndLocat } }); + int navigationIconResId = AndroidUtils.getNavigationIconResId(mapActivity); toolbarController = new PlanRouteToolbarController(); - toolbarController.setBackBtnIconIds(R.drawable.ic_action_mode_back, R.drawable.ic_action_mode_back); + toolbarController.setBackBtnIconIds(navigationIconResId, navigationIconResId); toolbarController.setTitle(getString(R.string.plan_route)); toolbarController.setOnBackButtonClickListener(new View.OnClickListener() { @Override diff --git a/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java b/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java index a929b7cc35..1299018bda 100644 --- a/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java +++ b/OsmAnd/src/net/osmand/plus/measurementtool/MeasurementToolFragment.java @@ -396,7 +396,8 @@ public class MeasurementToolFragment extends BaseOsmAndFragment { toolBarController = new MeasurementToolBarController(newGpxData); if (editingCtx.getSelectedPointPosition() != -1) { - toolBarController.setBackBtnIconIds(R.drawable.ic_action_mode_back, R.drawable.ic_action_mode_back); + int navigationIconResId = AndroidUtils.getNavigationIconResId(mapActivity); + toolBarController.setBackBtnIconIds(navigationIconResId, navigationIconResId); } else { toolBarController.setBackBtnIconIds(R.drawable.ic_action_remove_dark, R.drawable.ic_action_remove_dark); } @@ -973,7 +974,8 @@ public class MeasurementToolFragment extends BaseOsmAndFragment { private void switchMovePointMode(boolean enable) { if (enable) { - toolBarController.setBackBtnIconIds(R.drawable.ic_action_mode_back, R.drawable.ic_action_mode_back); + int navigationIconResId = AndroidUtils.getNavigationIconResId(getMapActivity()); + toolBarController.setBackBtnIconIds(navigationIconResId, navigationIconResId); } else { toolBarController.setBackBtnIconIds(R.drawable.ic_action_remove_dark, R.drawable.ic_action_remove_dark); } @@ -992,7 +994,8 @@ public class MeasurementToolFragment extends BaseOsmAndFragment { private void switchAddPointBeforeAfterMode(boolean enable) { if (enable) { - toolBarController.setBackBtnIconIds(R.drawable.ic_action_mode_back, R.drawable.ic_action_mode_back); + int navigationIconResId = AndroidUtils.getNavigationIconResId(getMapActivity()); + toolBarController.setBackBtnIconIds(navigationIconResId, navigationIconResId); } else { toolBarController.setBackBtnIconIds(R.drawable.ic_action_remove_dark, R.drawable.ic_action_remove_dark); } From 411236c5ce29ca02251442030bac0386bff64140 Mon Sep 17 00:00:00 2001 From: Nazar-Kutz Date: Thu, 30 Apr 2020 09:47:54 +0300 Subject: [PATCH 5/7] Fix wrong background (RTL) --- .../net/osmand/plus/mapcontextmenu/MapContextMenuFragment.java | 3 ++- .../net/osmand/plus/measurementtool/RecyclerViewFragment.java | 3 ++- .../osmand/plus/routepreparationmenu/ChooseRouteFragment.java | 3 ++- .../osmand/plus/routepreparationmenu/WaypointsFragment.java | 3 ++- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/OsmAnd/src/net/osmand/plus/mapcontextmenu/MapContextMenuFragment.java b/OsmAnd/src/net/osmand/plus/mapcontextmenu/MapContextMenuFragment.java index ab8f716b4f..2ac283d347 100644 --- a/OsmAnd/src/net/osmand/plus/mapcontextmenu/MapContextMenuFragment.java +++ b/OsmAnd/src/net/osmand/plus/mapcontextmenu/MapContextMenuFragment.java @@ -320,7 +320,8 @@ public class MapContextMenuFragment extends BaseOsmAndFragment implements Downlo if (menu.isLandscapeLayout()) { final TypedValue typedValueAttr = new TypedValue(); - mapActivity.getTheme().resolveAttribute(R.attr.left_menu_view_bg, typedValueAttr, true); + int bgAttrId = AndroidUtils.isLayoutRtl(app) ? R.attr.right_menu_view_bg : R.attr.left_menu_view_bg; + mapActivity.getTheme().resolveAttribute(bgAttrId, typedValueAttr, true); mainView.setBackgroundResource(typedValueAttr.resourceId); mainView.setLayoutParams(new FrameLayout.LayoutParams(menu.getLandscapeWidthPx(), ViewGroup.LayoutParams.MATCH_PARENT)); diff --git a/OsmAnd/src/net/osmand/plus/measurementtool/RecyclerViewFragment.java b/OsmAnd/src/net/osmand/plus/measurementtool/RecyclerViewFragment.java index 771e641079..fca7c80377 100644 --- a/OsmAnd/src/net/osmand/plus/measurementtool/RecyclerViewFragment.java +++ b/OsmAnd/src/net/osmand/plus/measurementtool/RecyclerViewFragment.java @@ -57,7 +57,8 @@ public class RecyclerViewFragment extends Fragment { final int backgroundColor = ContextCompat.getColor(getActivity(), nightMode ? R.color.activity_background_color_dark : R.color.activity_background_color_light); final TypedValue typedValueAttr = new TypedValue(); - getActivity().getTheme().resolveAttribute(R.attr.left_menu_view_bg, typedValueAttr, true); + int bgAttrId = AndroidUtils.isLayoutRtl(getActivity()) ? R.attr.right_menu_view_bg : R.attr.left_menu_view_bg; + getActivity().getTheme().resolveAttribute(bgAttrId, typedValueAttr, true); parent = new FrameLayout(mapActivity); parent.setLayoutParams(new LayoutParams(width + AndroidUtils.dpToPx(getActivity(), 16), height)); diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java index af0a286930..4ecc22f17b 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/ChooseRouteFragment.java @@ -147,7 +147,8 @@ public class ChooseRouteFragment extends BaseOsmAndFragment implements ContextMe solidToolbarView.setLayoutParams(new FrameLayout.LayoutParams(width, ViewGroup.LayoutParams.WRAP_CONTENT)); solidToolbarView.setVisibility(View.VISIBLE); final TypedValue typedValueAttr = new TypedValue(); - mapActivity.getTheme().resolveAttribute(R.attr.left_menu_view_bg, typedValueAttr, true); + int bgAttrId = AndroidUtils.isLayoutRtl(mapActivity) ? R.attr.right_menu_view_bg : R.attr.left_menu_view_bg; + mapActivity.getTheme().resolveAttribute(bgAttrId, typedValueAttr, true); view.findViewById(R.id.pager_container).setBackgroundResource(typedValueAttr.resourceId); view.setLayoutParams(new FrameLayout.LayoutParams(getResources().getDimensionPixelSize(R.dimen.dashboard_land_width), ViewGroup.LayoutParams.MATCH_PARENT)); } diff --git a/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java b/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java index c54ec92285..22ff37b4e7 100644 --- a/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java +++ b/OsmAnd/src/net/osmand/plus/routepreparationmenu/WaypointsFragment.java @@ -162,7 +162,8 @@ public class WaypointsFragment extends BaseOsmAndFragment implements ObservableS if (!portrait) { final TypedValue typedValueAttr = new TypedValue(); - mapActivity.getTheme().resolveAttribute(R.attr.left_menu_view_bg, typedValueAttr, true); + int bgAttrId = AndroidUtils.isLayoutRtl(mapActivity) ? R.attr.right_menu_view_bg : R.attr.left_menu_view_bg; + mapActivity.getTheme().resolveAttribute(bgAttrId, typedValueAttr, true); mainView.setBackgroundResource(typedValueAttr.resourceId); mainView.setLayoutParams(new FrameLayout.LayoutParams(getResources().getDimensionPixelSize(R.dimen.dashboard_land_width), ViewGroup.LayoutParams.MATCH_PARENT)); int width = getResources().getDimensionPixelSize(R.dimen.dashboard_land_width) - getResources().getDimensionPixelSize(R.dimen.dashboard_land_shadow_width); From d7d08810b39a273440d9042b9ef2ffb42f88c7c5 Mon Sep 17 00:00:00 2001 From: Nazar-Kutz Date: Thu, 30 Apr 2020 10:39:35 +0300 Subject: [PATCH 6/7] Fix "Route Preparation > Graph doesn't show numbers in slider" --- OsmAnd/res/layout/chart_marker_view.xml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/OsmAnd/res/layout/chart_marker_view.xml b/OsmAnd/res/layout/chart_marker_view.xml index 2cdde62cba..3f96eea59f 100644 --- a/OsmAnd/res/layout/chart_marker_view.xml +++ b/OsmAnd/res/layout/chart_marker_view.xml @@ -1,5 +1,5 @@ - @@ -31,7 +31,7 @@ android:textColor="@color/gpx_chart_blue" android:textStyle="bold" android:ellipsize="end" - android:singleLine="true"/> + android:maxLines="1"/> + android:maxLines="1"/> @@ -74,7 +74,7 @@ android:textColor="@color/gpx_chart_orange" android:textStyle="bold" android:ellipsize="end" - android:singleLine="true"/> + android:maxLines="1"/> + android:maxLines="1"/> @@ -109,7 +109,7 @@ android:textColor="@color/gpx_chart_green" android:textStyle="bold" android:ellipsize="end" - android:singleLine="true"/> + android:maxLines="1"/> + android:maxLines="1"/> - \ No newline at end of file + \ No newline at end of file From 3e21388e8ef17ee6bd0e547a159034ba028b78d9 Mon Sep 17 00:00:00 2001 From: Nazar-Kutz Date: Fri, 1 May 2020 11:17:42 +0300 Subject: [PATCH 7/7] small fixes --- OsmAnd/res/layout/fragment_map_markers_dialog.xml | 4 ++-- OsmAnd/res/layout/search_dialog_fragment.xml | 8 ++++---- .../SaveAsNewTrackBottomSheetDialogFragment.java | 6 ++---- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/OsmAnd/res/layout/fragment_map_markers_dialog.xml b/OsmAnd/res/layout/fragment_map_markers_dialog.xml index 3c7155e830..e9ab79f2a5 100644 --- a/OsmAnd/res/layout/fragment_map_markers_dialog.xml +++ b/OsmAnd/res/layout/fragment_map_markers_dialog.xml @@ -29,8 +29,8 @@ android:minHeight="@dimen/dashboard_map_toolbar" app:contentInsetLeft="54dp" app:contentInsetStart="54dp" - app:contentInsetRight="0dp" - app:contentInsetEnd="0dp"> + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp"> @@ -42,8 +42,8 @@ android:visibility="gone" app:contentInsetLeft="54dp" app:contentInsetStart="54dp" - app:contentInsetRight="0dp" - app:contentInsetEnd="0dp" + app:contentInsetRight="0dp" + app:contentInsetEnd="0dp" tools:visibility="visible">