From ab605a035ba9f494ce1cc8d2424a7eecb169a42b Mon Sep 17 00:00:00 2001
From: androiddevkotlin <64539346+androiddevkotlin@users.noreply.github.com>
Date: Mon, 12 Apr 2021 19:22:55 +0300
Subject: [PATCH] Bookmarking article without viewing it, adds empty GPX to My
 Places.

---
 .../travelcards/ArticleTravelCard.java        | 23 ++++++++++---------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/OsmAnd/src/net/osmand/plus/wikivoyage/explore/travelcards/ArticleTravelCard.java b/OsmAnd/src/net/osmand/plus/wikivoyage/explore/travelcards/ArticleTravelCard.java
index 92bbe1af95..e7b70ccb40 100644
--- a/OsmAnd/src/net/osmand/plus/wikivoyage/explore/travelcards/ArticleTravelCard.java
+++ b/OsmAnd/src/net/osmand/plus/wikivoyage/explore/travelcards/ArticleTravelCard.java
@@ -13,7 +13,6 @@ import com.squareup.picasso.Callback;
 import com.squareup.picasso.Picasso;
 import com.squareup.picasso.RequestCreator;
 
-import net.osmand.GPXUtilities;
 import net.osmand.PicassoUtils;
 import net.osmand.plus.OsmandApplication;
 import net.osmand.plus.R;
@@ -24,6 +23,8 @@ import net.osmand.plus.wikivoyage.article.WikivoyageArticleDialogFragment;
 import net.osmand.plus.wikivoyage.data.TravelArticle;
 import net.osmand.plus.wikivoyage.data.TravelLocalDataHelper;
 
+import static net.osmand.GPXUtilities.GPXFile;
+
 public class ArticleTravelCard extends BaseTravelCard {
 
 	public static final int TYPE = 2;
@@ -93,6 +94,8 @@ public class ArticleTravelCard extends BaseTravelCard {
 
 	private void updateSaveButton(final ArticleTravelVH holder) {
 		if (article != null) {
+			article = app.getTravelHelper().getArticleById(article.generateIdentifier(), article.getLang(), true,
+					null);
 			final TravelLocalDataHelper helper = app.getTravelHelper().getBookmarksHelper();
 			final boolean saved = helper.isArticleSaved(article);
 			Drawable icon = getActiveIcon(saved ? R.drawable.ic_action_read_later_fill : R.drawable.ic_action_read_later);
@@ -101,17 +104,15 @@ public class ArticleTravelCard extends BaseTravelCard {
 			holder.rightButton.setOnClickListener(new View.OnClickListener() {
 				@Override
 				public void onClick(View view) {
-					if (article != null) {
-						if (saved) {
-							GPXUtilities.GPXFile gpxFile = article.getGpxFile();
-							app.getSelectedGpxHelper().selectGpxFile(gpxFile, false, true);
-							helper.removeArticleFromSaved(article);
-						} else {
-							helper.addArticleToSaved(article);
-							app.getTravelHelper().createGpxFile(article);
-						}
-						updateSaveButton(holder);
+					if (saved) {
+						GPXFile gpxFile = article.getGpxFile();
+						app.getSelectedGpxHelper().selectGpxFile(gpxFile, false, true);
+						helper.removeArticleFromSaved(article);
+					} else {
+						helper.addArticleToSaved(article);
+						app.getTravelHelper().createGpxFile(article);
 					}
+					updateSaveButton(holder);
 				}
 			});
 		}