Commit graph

11193 commits

Author SHA1 Message Date
Nelson A. de Oliveira
17dce1efd8 Make some inner classes static
An inner class may be static if it doesn't reference its enclosing class
instance. A static inner class uses slightly less memory.
2013-08-03 10:48:26 -03:00
Nelson A. de Oliveira
c9dd6c0697 Make some fields static
A field may be static if it is declared final, and is initialized with a
constant
2013-08-03 10:48:18 -03:00
Nelson A. de Oliveira
8d3c8b6e9e Fix long literals ending with l
These literals may be confusing, as lowercase 'l' looks very similar to
'1'
2013-08-03 10:48:11 -03:00
Nelson A. de Oliveira
dad7d53f43 Remove unnecessary boxing/unboxing 2013-08-03 10:47:53 -03:00
Nelson A. de Oliveira
45b43e4311 Remove unnecessary returns
return is unnecessary as the last statement in a 'void' method
2013-08-03 10:47:34 -03:00
Nelson A. de Oliveira
f5be65b96e Simplify boolean expressions 2013-08-03 10:47:22 -03:00
Nelson A. de Oliveira
eb1a8d2f46 Fix duplicated branch 2013-08-03 10:46:49 -03:00
Nelson A. de Oliveira
0fe03b0f21 Remove unnecessary calls to String.valueOf() 2013-08-03 10:45:03 -03:00
Nelson A. de Oliveira
650b6b2362 Replace concat() call with +
Such calls can be replaced with the '+' operator for increased code
clarity and possible increased performance if the method was invoked on
a constant with a constant argument.
2013-08-03 10:44:54 -03:00
Nelson A. de Oliveira
dd615c9086 Use wrap_content in ScrollView
ScrollView children must set their layout_width or layout_height
attributes to wrap_content rather than fill_parent or match_parent in
the scrolling dimension.

This LinearLayout should use android:layout_height="wrap_content"
2013-08-03 10:43:04 -03:00
Nelson A. de Oliveira
bcab94e54f Fix inefficient layout weight
When only a single widget in a LinearLayout defines a weight, it is more
efficient to assign a width/height of 0dp to it since it will absorb all
the remaining space anyway. With a declared width/height of 0dp it does
not have to measure its own size first.
2013-08-03 10:42:47 -03:00
Nelson A. de Oliveira
a6f9976973 Fix buttons order
Layout uses the wrong button order for API >= 14:
Cancel button should be on the left (was "Save | Cancel", should be
"Cancel | Save")
2013-08-03 10:42:38 -03:00
Nelson A. de Oliveira
4c90f4aef3 Replace StringBuffer.toString() in concatenation
In addition to being confusing, this code performs String allocation and
copying, which is unnecessary as of JDK1.4
2013-08-03 10:42:31 -03:00
Nelson A. de Oliveira
20f18fd5a6 Fix single character string argument
These String literals may be replaced by equivalent character literals,
gaining some performance enhancement.
2013-08-03 10:42:15 -03:00
Nelson A. de Oliveira
db7346ea53 Fix redundant toString() on a String object 2013-08-03 10:42:08 -03:00
Nelson A. de Oliveira
7901e95fac Fix manual array copy 2013-08-03 10:40:59 -03:00
Roberto GEB
b84df845a2 Translated using Weblate. 2013-08-03 12:05:05 +02:00
sonora
730c11179e resort simulation dialogue a bit better 2013-08-03 09:08:41 +02:00
ezjerry liao
ca60148431 Translated using Weblate. 2013-08-03 00:05:04 +02:00
sonora
99562820fc put amenity=emergency_phone to end as is outdated 2013-08-02 21:42:22 +02:00
sonora
3c1c230dcc pre-install major tts voices 2013-08-02 15:08:50 +02:00
sonora
2a89630ebf add reference to language identifiers in en and de strings 2013-08-02 14:54:11 +02:00
Petr Kulhavy
bc4f743b6a Translated using Weblate. 2013-08-02 12:00:02 +02:00
vshcherb
7f4c2883cc Merge pull request #484 from naoliv/master
Some misc fixes
2013-08-01 15:22:38 -07:00
Roberto GEB
e788d5ada0 Translated using Weblate. 2013-08-01 21:05:07 +02:00
Ludek M
d7397a181f Translated using Weblate. 2013-08-01 21:05:07 +02:00
sonora
dc96d250a3 fix speed_alarm prompt 2013-08-01 19:29:28 +02:00
Leif Larsson
d79687f366 Translated using Weblate. 2013-08-01 12:00:05 +02:00
Roberto GEB
09a5b1086b Translated using Weblate. 2013-08-01 12:00:04 +02:00
Przemo Firszt
68d8bbde75 Translated using Weblate. 2013-08-01 00:00:02 +02:00
Mirco Zorzo
9390e6dbaa Translated using Weblate. 2013-08-01 00:00:02 +02:00
Nelson A. de Oliveira
a525df7694 Fix unnecessary bitwise operations 2013-07-31 15:39:50 -03:00
Nelson A. de Oliveira
ffaaef6610 Remove unecessary semicolon 2013-07-31 15:24:57 -03:00
Nelson A. de Oliveira
50207ec316 Remove continue and return 2013-07-31 15:24:15 -03:00
Nelson A. de Oliveira
bf05917be5 Remove redundant local variables 2013-07-31 15:22:39 -03:00
Nelson A. de Oliveira
1eea84da0b Fix unnecessary boxing/unboxing 2013-07-31 15:15:26 -03:00
Nelson A. de Oliveira
1bdb389eae Fix pointless aithmetic expressions 2013-07-31 15:14:11 -03:00
Nelson A. de Oliveira
61699455e5 Replace StringBuffer with String
These may be replaced with java.lang.String expressions which results in
simpler and possibly more efficient code
2013-07-31 15:09:37 -03:00
Nelson A. de Oliveira
a0de8b31b3 Fix string concatenation in StringBuffer.append()
Such calls may profitably be turned into chained append calls on the
existing StringBuffer/Builder/Appendable, saving the cost of an extra
StringBuffer/Builder allocation.
2013-07-31 15:08:29 -03:00
Nelson A. de Oliveira
6a3f36761c Fix redundant String constructor call 2013-07-31 15:07:07 -03:00
Nelson A. de Oliveira
6fc309af19 Fix manual array to collection copy 2013-07-31 15:06:31 -03:00
Nelson A. de Oliveira
ffc006bab6 Fix boxing of already boxed values
This is a useless operation since any boxed value will first be
auto-unboxed before boxing the value again. If done inside an inner loop
such code may cause performance problems.
2013-07-31 15:05:59 -03:00
sonora
18989fcc9f bundle new sw-tts and zh-tts 2013-07-31 15:31:59 +02:00
sonora
8f35a07676 bundle new sv-tts 2013-07-31 14:39:17 +02:00
sonora
14f4a76c10 bundle new sl-tts 2013-07-31 14:17:04 +02:00
sonora
01be013e2b bundle new sk-tts 2013-07-31 13:46:01 +02:00
sonora
187e0db9c3 bundle new ro-tts 2013-07-31 12:47:31 +02:00
Victor Shcherb
c4f040f2aa Add GPX point for Recordings only when logging to GPX 2013-07-31 11:04:55 +02:00
Victor Shcherb
c949508846 Fix apostrophe 2013-07-31 11:04:55 +02:00
Victor Shcherb
f8200a6737 Fix apostrophe 2013-07-31 11:04:55 +02:00