Thelie/python-feedgen
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove redundant media from method name

Browse source 
Using `fe.media.media_content(…)` is quite redundant. iThis patch
changes the name to `fe.media.content(…)`. The same goes for the
thumbnail method.

Part of #58
This commit is contained in:
Lars Kiesow 2017-05-21 12:58:13 +02:00
parent 8487af298e
commit a7ae36cb4f
No known key found for this signature in database
GPG key ID: 5DAFE8D9C823CE73
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
feedgen/ext/media.py
View file

@ -87,10 +87,10 @@ class MediaEntryExtension(BaseEntryExtension):
def extend_rss(self, item): def extend_rss(self, item):
return self.extend_atom(item) return self.extend_atom(item)
def media_content(self, url=None, fileSize=None, type=None, medium=None, def content(self, url=None, fileSize=None, type=None, medium=None,
isDefault=None, expression=None, bitrate=None, isDefault=None, expression=None, bitrate=None, framerate=None,
framerate=None, samplingrate=None, channels=None, samplingrate=None, channels=None, duration=None, height=None,
duration=None, height=None, width=None, lang=None): width=None, lang=None):
'''<media:content> is a sub-element of either <item> or <media:group>. '''<media:content> is a sub-element of either <item> or <media:group>.
Media objects that are not the same content should not be included in Media objects that are not the same content should not be included in
the same <media:group> element. The sequence of these items implies the same <media:group> element. The sequence of these items implies
@ -152,7 +152,7 @@ class MediaEntryExtension(BaseEntryExtension):
return self.__media_content return self.__media_content
def media_thumbnail(self, url=None, height=None, width=None, time=None): def thumbnail(self, url=None, height=None, width=None, time=None):
'''Allows particular images to be used as representative images for '''Allows particular images to be used as representative images for
the media object. If multiple thumbnails are included, and time the media object. If multiple thumbnails are included, and time
coding is not at play, it is assumed that the images are in order coding is not at play, it is assumed that the images are in order

2
tests/test_extension.py
View file

@ -211,7 +211,7 @@ class TestExtensionMedia(unittest.TestCase):
fe.id('id') fe.id('id')
fe.title('title') fe.title('title')
fe.content('content') fe.content('content')
fe.media.media_content(url='file1.xy') fe.media.content(url='file1.xy')
ns = {'media': 'http://search.yahoo.com/mrss/', ns = {'media': 'http://search.yahoo.com/mrss/',
'a': 'http://www.w3.org/2005/Atom'} 'a': 'http://www.w3.org/2005/Atom'}